TimeTextBox: mouseover changes starting value

[Adam Peller]

This one's kind of hard to describe - if you happen to have your mouse at the location of the popup when you tab into a field, the mouse position will affect the value, even if you never click the mouse.

If you bring up the test_TimeTextBox example and tab through all the fields, you'll get the values, unchanged as you'd expect. However, if you bring up the first value then select another time (like 4:00PM) with the mouse, leave the mouse still and tab through all of the fields. You'll see the values change.

[David Schwartz]

I don't see the pop-up control with which to choose another value with the mouse.

[Adam Peller]

click on the input box and you will see a vertical drop down with a range of times to select from 2:00 3:00 4:00 with lines in between representing 15 minute intervals. This is the popup I'm speaking of.

[David Schwartz]

I was using FF3 and the pop-ups weren't displaying. It works as you describe on IE7 for me. Right, so, the problem, of course, is that values are being selected based on hover rather than click. I assume that's a bug, no? I wouldn't imagine that it'd be the intended design.

This is true for scrolling as well, i.e., it should occur only on mouseDown.

[Adam Peller]

if clicking on a TimeTextBox? on any platform does not result in a popup, that's a serious bug. (Works for me on FF3)

Yeah, I think it's the intended design, but one that needs to be thought through a bit more. Changing the widget state accidentally (w/o selecting it with focus/clicking) sounds like something which needs redesign.

[bill]

TimeTextBox widget is wanting a big overhaul (see #7631), maybe we should wait until then to fix this... anyway scheduling for 1.4 for now.

I looked at the code for dijit._TimePicker and it seems to call _onItemSelected() on onclick, so not sure why this problem is happening.

[bill]

Oh I see, it's because just tabbing away from the _TimePicker will select the hovered value, even though it wasn't clicked and neither the ENTER or SPACE key was pressed. It's because of this code in TimePicker.js which treats tab as selection:

}else if(this._highlighted_option && (e.charOrCode == dk.ENTER || e.charOrCode === dk.TAB)){
        // Accept the currently-highlighted option as the value
        if(e.charOrCode == dk.ENTER){dojo.stopEvent(e);}
        setTimeout(dojo.hitch(this, function(){
                this._onOptionSelected({target: this._highlighted_option});
        }),1);
}

Maybe we should just remove the TAB from the if()?

[Douglas Hays]

possible fix, not allowing TAB to select unless preceded by keyboard activity

[Douglas Hays]

peller, does this patch work for you?

[Adam Peller]

(In [20362]) Committing Doug's patch, fixes #7842. Now tabbing through a TimeTextBox? will not change the value if the user mouses over the popup without clicking. !strict