Opened 11 years ago

Closed 11 years ago

#7818 closed defect (fixed)

Firebug Lite appears incorrectly on Minefield builds of Firefox

Reported by: alex Owned by: alex
Priority: high Milestone: 1.3
Component: Core Version: 1.2.0
Keywords: Cc:
Blocked By: Blocking:

Description

detection code in Firebug Lite tries to detect the Firefox version and not Mozilla. This leads to Firebug Lite appearing in places it shouldn't:

if(
   !dojo.config.useCustomLogger &&
   !dojo.isAIR &&                                   // isDebug triggers AIRInsector, not Firebug
   (!dojo.isFF ||                                  // if not Firefox, there's no firebug
    (dojo.isFF && !("console" in window)) ||       // Firefox, but Firebug is not installed.
    (dojo.isFF && !(window.loadFirebugConsole || console.firebug)) &&  // Firefox, but Firebug is disabled (1.2 check, 1.0 check)
    !dojo.config.noFirebugLite                      // Deprecated: Should be isDebug=false
)){

should be:

if(
   !dojo.config.useCustomLogger &&
   !dojo.isAIR &&                                   // isDebug triggers AIRInsector, not Firebug
   (!dojo.isMoz ||                                  // if not Firefox, there's no firebug
    (dojo.isMoz && !("console" in window)) ||       // Firefox, but Firebug is not installed.
    (dojo.isMoz && !(window.loadFirebugConsole || console.firebug)) &&  // Firefox, but Firebug is disabled (1.2 check, 1.0 check)
    !dojo.config.noFirebugLite                      // Deprecated: Should be isDebug=false
)){

Change History (1)

comment:1 Changed 11 years ago by alex

Resolution: fixed
Status: newclosed

(In [15418]) fix to prevent Firebug Lite from popping up in Firefox Minefield builds. Fixes #7818. !strict

Note: See TracTickets for help on using tickets.