Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7816 closed defect (fixed)

[patch]Grid: find alternatives to "no data" string

Reported by: Adam Peller Owned by: Nathan Toone
Priority: high Milestone: 1.2.1
Component: DojoX Grid Version: 1.2beta
Keywords: i18n Cc: Becky Gibson, David Schwartz
Blocked By: Blocking:

Description

see #7961

Not sure "no data" is the best visual indication to users. What's ideal? According to becky, an empty grid would be accessible and that might be our easiest way out, at least for 1.2.x, though it provides no confirmation to the user that the grid has actually loaded.

It would be great to come up with a language-neutral solution, like a graphic or shading, to avoid the translation bundle with a single string and keep the UI simple and neutral.

Attachments (1)

7816_gridNoDataMessages-1.2.patch (1.9 KB) - added by Nathan Toone 11 years ago.
patch against 1.2 branch which fixes this issue

Download all attachments as: .zip

Change History (11)

comment:1 Changed 11 years ago by Nathan Toone

So - not sure what is being asked here. You can set noDataMessage to be "" on any grid you create if you want to remove the message. Are you suggesting we make that the default?

comment:2 Changed 11 years ago by Adam Peller

yup. mostly because I want to avoid a translation round, but also because I'm not sure it's the right UI. " by default with user-overrides would be a good solution for now.

comment:3 Changed 11 years ago by Nathan Toone

Owner: changed from Bryan Forbes to Nathan Toone
Status: newassigned

comment:4 Changed 11 years ago by Nathan Toone

Fixed in trunk in [15456]

comment:5 Changed 11 years ago by Nathan Toone

with a couple of cleanup fixes in [15457] and [15458]

Changed 11 years ago by Nathan Toone

patch against 1.2 branch which fixes this issue

comment:6 Changed 11 years ago by Nathan Toone

Summary: Grid: find alternatives to "no data" string[patch]Grid: find alternatives to "no data" string

comment:7 Changed 11 years ago by Nathan Toone

Priority: normalhigh

This is probably a higher priority - since we really should have localization hammered out.

comment:8 Changed 11 years ago by Nathan Toone

Resolution: fixed
Status: assignedclosed

Fixed in branch with revision [15471]

comment:9 Changed 11 years ago by David Schwartz

This one's tough. Really, the only plausible candidate is something like http://i72.photobucket.com/albums/i199/RaspK_FOG/Empty-Set-Black.png. However, I wouldn't be surprised if that would be meaningless to some users. This is easy enough to test. So, no columns would be shown, just the symbol centered at the top of the grid.

comment:10 Changed 11 years ago by David Schwartz

Where can I test this fix? The following doesn't seem to address the issue.

http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_data_grid_empty.html

Note: See TracTickets for help on using tickets.