Opened 11 years ago

Closed 6 years ago

#7815 closed defect (patchwelcome)

FF3 does not display editor toolbar

Reported by: matt5218 Owned by: Bryan Forbes
Priority: blocker Milestone: future
Component: DojoX Grid Version: 1.2.0
Keywords: Cc:
Blocked By: Blocking:

Description

Firefox 3 does not display editor toolbar for cell type: dojox.grid.cells.Editor

Open message column: http://download.dojotoolkit.org/current-stable/dojo-release-1.2.0/dojox/grid/tests/test_edit_dijit.html

Change History (11)

comment:1 Changed 11 years ago by Bryan Forbes

Milestone: tbd1.3

comment:2 Changed 11 years ago by Bryan Forbes

Priority: normalhigh

comment:3 Changed 10 years ago by bill

Milestone: 1.31.4

1.3rc1 has been release; bumping remaining tickets to 1.4 (except for documentation/testing tickets)

comment:4 Changed 10 years ago by nic

Related to #6001 (same problem on IE6/7? I can't test now on IE6/7, but works for me on IE8)
Bug still present on FF3.5
http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_edit_dijit.html

comment:5 Changed 10 years ago by Nathan Toone

Milestone: 1.41.5

Moving non-regressions to 1.5

comment:6 Changed 10 years ago by Goran Miskovic

After removing isMoz check in formatNode method of dojox.grid.cells.Editor (dojox/grid/cells.dijit.js on line 202, Dojo 1.4) toolbar is displayed. Tested in FF 3.5.7 and Google Chrome 4.0.288.1 unstable running on Ubuntu Karmic Koala.

Index: dijit.js
--- dijit.js Base (BASE)
+++ dijit.js Locally Modified (Based On LOCAL)
@@ -199,14 +199,6 @@
 		formatNode: function(inNode, inDatum, inRowIndex){
 			this.content = inDatum;
 			this.inherited(arguments);
-			if(dojo.isMoz){
-				// FIXME: seem to need to reopen the editor and display the toolbar
-				var e = this.widget;
-				e.open();
-				if(this.widgetToolbar){
-					dojo.place(e.toolbar.domNode, e.editingArea, "before");
-				}
-			}
 		},
 		populateEditor: function(){
 			this.widget.attr('value', this.content);

comment:7 Changed 9 years ago by bill

Milestone: 1.51.6

1.5 is released, moving remaining tickets to 1.6

comment:8 Changed 8 years ago by bill

Milestone: 1.6future

(sadly) punting seemingly abandoned ticket and meta tickets to future

comment:9 Changed 8 years ago by Colin Snover

Priority: highblocker

Bulk update of open ticket priorities.

comment:10 Changed 6 years ago by bill

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:11 Changed 6 years ago by bill

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.