Opened 11 years ago

Closed 11 years ago

#7789 closed defect (fixed)

dojox.widget.Dialog patch to rename fixedSize param and doc issues

Reported by: Josh Trutwin Owned by: dante
Priority: high Milestone: 1.3
Component: DojoX Widgets Version: 1.2beta
Keywords: dojox.widget.Dialog fixedSize Cc:
Blocked By: Blocking:

Description

Patch attached to rename fixedSize param to sizeToViewport (for lack of something even better). fixedSize="true" actual meant that the dialog would size according to viewport minus padding, where as fixedSize="false" really meant a "fixed size" by supplying dimensions or using default 300x300. sizeToViewport seems to better describe what's going on here though it certainly could be better named to use more user-friendly terminology.

Also clarified some of the source documentation comments a bit.

Patched against trunk, updated test file. (and this time I tested first!)

Attachments (1)

dojox_Dialog.patch (4.2 KB) - added by Josh Trutwin 11 years ago.
dojox.widget.Dialog fixedSize patch

Download all attachments as: .zip

Change History (2)

Changed 11 years ago by Josh Trutwin

Attachment: dojox_Dialog.patch added

dojox.widget.Dialog fixedSize patch

comment:1 Changed 11 years ago by dante

Milestone: tbd1.3
Resolution: fixed
Status: newclosed

fixed in [15825]

Note: See TracTickets for help on using tickets.