Opened 11 years ago

Closed 11 years ago

#7787 closed defect (fixed)

[patch]Grid toggling an initially-hidden column does not show up

Reported by: Nathan Toone Owned by: Nathan Toone
Priority: high Milestone: 1.2.1
Component: DojoX Grid Version: 1.2beta
Keywords: Cc:
Blocked By: Blocking:

Description

If you have a %-width-specified column that is initially hidden in your structure, turning that column on will not display the column - since it is getting calculated as 0-width.

The fix is to move the call to convertColPctToFixed to happen *AFTER* the update when setting column visibility

Attachments (1)

7787_gridColumnToggling-1.2.patch​ (430 bytes) - added by Nathan Toone 11 years ago.
Single patch against 1.2 to fix this issue, possibly for inclusion

Download all attachments as: .zip

Change History (11)

comment:1 Changed 11 years ago by Nathan Toone

(In [15402]) Refs #7787 - address initially-hidden column visibility in trunk !strict

comment:2 Changed 11 years ago by Nathan Toone

This fix only works for toggling the first initially-empty column. It requires more investigation.

comment:3 Changed 11 years ago by Nathan Toone

Milestone: 1.2.1 → 1.3

Moving to milestone 1.3 - looks like the fix will be a bit more involved than we'll want to put into the branch.

comment:4 Changed 11 years ago by Nathan Toone

Resolution: → fixed
Status: new → closed

(In [15404]) Fixes #7787 - there is no need to call convertColPctToFixed when simply toggling hidden states on and off. This is a simple fix - so we can decide later whether or not to open this bug and apply to the 1.2 branch as well. !strict

comment:5 Changed 11 years ago by bill

Component: General → DojoX Grid

comment:6 Changed 11 years ago by Nathan Toone

Milestone: 1.3 → 1.2.1
Resolution: fixed
Status: closed → reopened

Reopening against 1.2.1 - for deciding later if we want to merge it.

comment:7 Changed 11 years ago by Nathan Toone

Status: reopened → new

comment:8 Changed 11 years ago by Nathan Toone

Status: new → assigned

Changed 11 years ago by Nathan Toone

Attachment: 7787_gridColumnToggling-1.2.patch​ added

Single patch against 1.2 to fix this issue, possibly for inclusion

comment:9 Changed 11 years ago by Nathan Toone

Summary: Grid toggling an initially-hidden column does not show up → [patch]Grid toggling an initially-hidden column does not show up

comment:10 Changed 11 years ago by Nathan Toone

Resolution: → fixed
Status: assigned → closed

Fixed in branch in revision [15473]

Note: See TracTickets for help on using tickets.