Changes between Initial Version and Version 1 of Ticket #7770


Ignore:
Timestamp:
Oct 1, 2008, 9:18:31 AM (12 years ago)
Author:
bill
Comment:

We debated this at length a few months ago, and decided to add gutters (both between panes and around the edges of the BorderContainer) by default, since we want dijit to look good out of the box. There's obviously a tradeoff where some existing applications will be hurt (but I think most will look better).

You can easily disable it across your application by doing:

.dijitBorderContainer { padding: 0px !important;  }
.dijitGutterH { height: 0px !important; }
.dijitGutterV { width: 0px !important; }

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7770

    • Property Status changed from new to closed
    • Property Resolution changed from to wontfix
  • Ticket #7770 – Description

    initial v1  
    1 With 1.2, the BorderContainer now has gutters. Using markup creation, not adding a gutters attribute will default gutters to TRUE. This is against standard API design (new features are disabled by default), and will also make all existing apps that use BorderContainers look 'different'. This might seem a trivial point, but some apps will have 100s of BorderContainers that should not need to be amended for a backwards compatible release. Can we default gutters to FALSE so that existing dojo users don't have to do extra work on the upgrade?
     1With 1.2, the !BorderContainer now has gutters. Using markup creation, not adding a gutters attribute will default gutters to TRUE. This is against standard API design (new features are disabled by default), and will also make all existing apps that use BorderContainers look 'different'. This might seem a trivial point, but some apps will have 100s of BorderContainers that should not need to be amended for a backwards compatible release. Can we default gutters to FALSE so that existing dojo users don't have to do extra work on the upgrade?