Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7770 closed defect (wontfix)

BorderContainer gutters should default to false not true

Reported by: andy Owned by:
Priority: high Milestone: tbd
Component: Dijit Version: 1.2beta
Keywords: BorderContainer gutters default Cc:
Blocked By: Blocking:

Description (last modified by bill)

With 1.2, the BorderContainer now has gutters. Using markup creation, not adding a gutters attribute will default gutters to TRUE. This is against standard API design (new features are disabled by default), and will also make all existing apps that use BorderContainers? look 'different'. This might seem a trivial point, but some apps will have 100s of BorderContainers? that should not need to be amended for a backwards compatible release. Can we default gutters to FALSE so that existing dojo users don't have to do extra work on the upgrade?

Change History (2)

comment:1 Changed 11 years ago by bill

Description: modified (diff)
Resolution: wontfix
Status: newclosed

We debated this at length a few months ago, and decided to add gutters (both between panes and around the edges of the BorderContainer) by default, since we want dijit to look good out of the box. There's obviously a tradeoff where some existing applications will be hurt (but I think most will look better).

You can easily disable it across your application by doing:

.dijitBorderContainer { padding: 0px !important;  }
.dijitGutterH { height: 0px !important; }
.dijitGutterV { width: 0px !important; }

comment:2 Changed 11 years ago by dante

or dijit._Widget.prototype.gutters = false; maybe

Note: See TracTickets for help on using tickets.