[patch] [cla] Tree: Add a "getIconStyle" method

[rdunklau]

It would be nice to have a "getIconStyle" method , similar to the "getIconClass" one. That would allow specific/dynamics tree icons. A simple example where it would be useful : if you want to display a tree which nodes represents music albums, you don't want to create a css class per node. Moreover, it would be consistent with what already exists for the grid widget.

[bill]

Sure, I guess that makes sense. It would typically return something like "background-image: url(album1.jpg)" ?

[rdunklau]

Replying to bill:

Sure, I guess that makes sense. It would typically return something like "background-image: url(album1.jpg)" ?

Yes, that's exactly how i imagined it. By the way, it should also prosose a "getLabelStyle" for the same purpose.

[rdunklau]

I implemented it, the same way onStyleRow was implemented for the grid, since i did not know how to parse a CSS declaration. So i used the very same _setStyleText that was used in grid RowManager?.

Is there a way to use dojo.style instead ?

Here comes a patch (WARNING : it comes with the modification i posted on #7717), along with a test case.

[rdunklau]

Test Case

[rdunklau]

Patch including change for #7710 and #7717

[bill]

Hi rdunklau, thanks for the patch!

The way to use dojo.style() to "set the whole style" is to pass it an object, ex:

dojo.style("thinger", {
	"opacity": 0.5,
	"border": "3px solid black",
	"height": 300
});

I wonder if having getIconStyle() return an Object might be a better API than returning a string?

Also, for the double-click handler is there a reason to have the onDblClick open option on the Tree. I don't want to add options to Tree unless they are really useful.

[rdunklau]

I think it may be useful if you want to use the drag'n'drop feature : a simple click can not be used to expand the node, but developers may want to provide another option to perform node expanding. I'm no ergonomy expert, but this option could be useful. As for the getIconStyle method, the implementation was inspired by the grid onStyleRow method.

[bill]

I see.

I thought of a reason to return a dojo.style() parameter Object... so that dojo.style can do normalization like for setting opacity.

Anyway, I will modify the patch slightly to work with objects and then check it in.

[bill]

Checked in by [15693], thanks for the patch!