Opened 11 years ago

Closed 11 years ago

#7700 closed defect (fixed)

Move dojox.editor refactor to a separate dir

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.2
Component: Dojox Version: 1.2beta
Keywords: Cc: Mike Wilcox, Dustin Machi
Blocked By: Blocking:

Attachments (1)

dojox-editor-cleanup.patch (169.0 KB) - added by Adam Peller 11 years ago.
remove dojox.Editor (refactored copy of Editor, to be placed on branch) Rollback changes so plugins point at dijit.Editor again.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by Adam Peller

specifically, an exception is thrown

this.editor.editorObject is undefined

comment:2 Changed 11 years ago by Adam Peller

Description: modified (diff)
Milestone: tbd1.2
Summary: ToggleDir plugin is brokenMove dojox.editor refactor to a separate dir

ugh, this is because the dijit.Editor plugins from the b0rken merge were put in the same directory as dojox plugins. This won't fly for 1.2. We have to move them.

comment:3 Changed 11 years ago by bill

Regarding the original title of this that "ToggleDir? plugin is broken": ToggleDir? plugin in dijit is working fine, see http://download.dojotoolkit.org/release-1.2.0rc1/dojo-release-1.2.0rc1/dijit/tests/_editor/test_ToggleDir.html

ToggleDir? plugin for the new Editor code (http://download.dojotoolkit.org/release-1.2.0rc1/dojo-release-1.2.0rc1/dojox/editor/tests/test_ToggleDir.html) isn't working yet, but that shouldn't be alarming since the new Editor code isn't finished yet.

ugh, this is because the dijit.Editor plugins from the b0rken merge were put in the same directory as dojox plugins. This won't fly for 1.2. We have to move them.

I'm not sure what this means. Presumably by "dojox plugins" you are talking about the table plugin and file uploader plugin, but AFAIK neither of those works against the old Editor code in dijit, so even if you split dojox.editor into two directories it wouldn't get you anything.

comment:4 Changed 11 years ago by Adam Peller

Cc: Mike Wilcox added

comment:5 Changed 11 years ago by Adam Peller

Cc: Dustin Machi added

Changed 11 years ago by Adam Peller

Attachment: dojox-editor-cleanup.patch added

remove dojox.Editor (refactored copy of Editor, to be placed on branch) Rollback changes so plugins point at dijit.Editor again.

comment:6 Changed 11 years ago by Adam Peller

will need to port [15005] and [15096] to editor_refactor branch

comment:7 Changed 11 years ago by liucougar

[15331] needs to be ported as well

comment:8 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: newclosed

Branch can be created from [14991] when needed, and new patches including those referenced here merged to the branch.

Note: See TracTickets for help on using tickets.