[meta] commit dijit robot tests

[Douglas Hays]

Use this ticket to drop the initial wave of robot automated tests for dijit.

[Douglas Hays]

(In [15280]) References #7681. The robot code should execute with the same BASE as the page being tested so that XHR gets work correctly (Safari 3.1 seems to require this).

[Douglas Hays]

(In [15281]) References #7681. Proxy commit for haysmark. Initial drop of the unified combobox/filteringselect unit tests and robot tests.

[Douglas Hays]

(In [15315]) References #7681. Proxy commit for haysmark. Commit Spinner robot test.

[Douglas Hays]

(In [15408]) References #7681. Proxy commit for haysmark. Commit Slider robot test. Fix test failure where clicking the end of the slider bar was being allowed even for disabled sliders.

[bill]

(In [16638]) Beginnings of automated tests for Menu.

Refs #7681 !strict.

[bill]

(In [16667]) Test infrastructure updates, as discussed with Mark:

• Allow test page to listen to topics published by child page
• Use dojo.setContext() to point parent page to child page, so that dojo.global also gets redefined, in addition to dojo.doc... that lets test code easily access variables in the child by referencing dojo.global.foo, or perhaps more correctly by calling dojo.getObject()

Refs #7681

[bill]

(In [16668]) Finish very basic mouse tests for MenuBar?, and start MenuBar? keyboard tests. Adding id's into dijit/tests/test_Menu.html just to make writing the tests easier. Refs #7681

[bill]

(In [16715]) Continuation of [16667], use dojo.global to access child page. Refs #7681.

[bill]

(In [16798]) More keyboard tests for MenuBar?, and mouse tests for navigation menu. Refs #7681.

[bill]

(In [16828]) Tests for page-level context menu, plus changes to make test run on IE in addition to FF. Safari still doesn't work though. Refs #7681.

[bill]

(In [16829]) Split menu tests into keyboard tests and mouse tests. Only the mouse tests work on safari (because dijit doesn't support keyboard on safari). Refs #7681.

[bill]

(In [16833]) Split spinner tests into keyboard tests and mouse tests. Only the mouse tests work on safari, although unclear if that's because dijit doesn't fully support keyboard on safari, or if it's a regression. Refs #7681.

[bill]

(In [16834]) Split slider tests into keyboard tests and mouse tests. Keyboard tests don't work on safari since we can't focus the handle of the slider, thus can't send keyboard commands to it. Refs #7681.

[Joseph Scheuhammer]

Replying to bill:

(In [16834]) Split slider tests into keyboard tests and mouse tests. Keyboard tests don't work on safari since we can't focus the handle of the slider, thus can't send keyboard commands to it. Refs #7681.

Just a note that keyboard tests *do* work for Safari 4 beta. (So far I've run the slider and tree robot tests).

[bill]

(In [16839]) Comments and TODO items. Refs #7681.

[bill]

(In [16840]) Fix robotTests.js to run the Menu test, and also to run a11y only on browsers that support them. Refs #7681.

[bill]

(In [16841]) Spinner tests:

• use dojo.is() and attr('value') directly, not displayData() which makes a hard-to-parse string
• no need to test final values in a special "tearDown" test... each individual test can check final values

Refs #7681.

[bill]

(In [16842]) Slider tests:

• use dojo.is() and attr('value') directly, not displayData() which makes a hard-to-parse string
• no need to test final values in a special "tearDown" test... each individual test can check final values

Refs #7681.

[bill]

(In [16843]) When running from robotTests.html, moving mouse to (0,0) for some reason interfers with next test (making it seem to hang), so move to (2,2) instead. Refs #7681.

[bill]

(In [16844]) Scroll test needs a little bit longer than the default timeout, at least on FF3/mac. It's taking 8s on my machine but setting timeout to 20s for safety. Refs #7681.

[Joseph Scheuhammer]

Replying to bill:

(In [16840]) Fix robotTests.js to run the Menu test, and also to run a11y only on browsers that support them. Refs #7681.

While it makes sense to run keyboard a11y tests only in browsers that support them, the same is not true of the aria tests (roles, states, and properties).

The aria tests are checking that the dijit widget was properly constructed -- that it has the proper role, the required and supported states/properties. That's independent of the browser. The aria info will be set and manipulated by the object's code, even when run in browsers that do not support aria.

A solution is to parcel out the aria tests. For example, have a "Slider_mouse.html", a "Slider_keyboard.html", and a "Slider_aria.html".

[Douglas Hays]

(In [16849]) References #7681. Removed mouse robot commands from keyboard Spinner test.

[bill]

(In [16922]) Removed mouse robot commands from keyboard Slider test. Refs #7681.

[bill]

(In [16991]) Automated tests for dijit.placeOnScreen() and dijit.placeOnScreenAroundElement(). Refs #7681.

[bill]

(In [17637]) Initial robot tests for DateTextBox? and Calendar widgets. Working on IE6, FF3/PC, and Safari3/Mac, although failing on FF3/mac (but that's generally unreliable for robot tests).

Refs #7681 !strict.

[bill]

(In [17638]) Localization tests for Calendar widget, and adding test to main test suite.

Refs #7681 !strict.

[bill]

(In [17675]) A few Tooltip mouse automated tests. Most of the functionality was tested in Tooltip_a11y.html Also adding Tooltip tests to master robotTests.js file.

Refs #7681.

[bill]

(In [17732]) Beginnings of Tree DnD tests. Refs #7681.

[bill]

(In [17742]) Forgot to check this in before; updates for Tree_dnd.html to work. Refs #7681.

[bill]

(In [17743]) Tests for drop-between. I can't get the tests to run on FF/IE anymore (even before these changes); it's not noticing the mouseRelease call so Apple doesn't drop on Fruits correctly. Needs further investigation.

Refs #7681.

[bill]

(In [17769]) Get Tree DnD tests working on IE and FF; needed to add in more delays. Refs #7681.

[bill]

(In [17970]) Some simple automated but non-robot tests for Tree, in particular testing Tree/dojo.data interaction. Perhaps should remove test_Tree_Programmatic.html and test_Tree_Notification_API_Support.html as Tree.html tests the same functionality.

Updating countries.json to separate id and name attributes just so I can test modifying the name of an item / label of a tree node.

Refs #7681.

[bill]

(In [18043]) Fix trailing comma (breaking test on IE), refs #7681.

[bill]

(In [18044]) Changes corresponding to countries.json update in [17970], refs #7681.

[bill]

(In [19084]) Fix spurious error on negative keyboard test, and also be sure to use getErrback() inside of setTimeout() so that errors are properly reported. Refs #7681.

[bill]

(In [19109]) Avoid race condition on IE... apparently the disable call didn't take affect in time? Was getting failures on the disabled test when run from the main test harness. Refs #7681.

[bill]

(In [19116]) Fix spurious failures due to small viewport, and from rerunning the test. Refs #7681

[Douglas Hays]

(In [19985]) References #7681. Add check for when _curFocus is null (no widget has focus).

[bill]

(In [20114]) Remove spurious <body></body> at end of test file. Refs #7681.

[bill]

(In [20153]) Safari and Chrome need more time for the click to take effect and toggle the ToggleButton?. Refs #7681.

[bill]

(In [20441]) Get Spinner_mouse.html running on IE8, rather than hanging. Changed a bunch of tests that didn't (seem to) make sense, including:

1. Multiple dojo.register("foo", ...) calls w/same "foo" name. Used array argument to dojo.register() instead.
2. "0.5" is not an invalid value, changed test to type "0.a"
3. "A11y" test group doesn't test a11y, that's what Spinner_a11y.html is for
4. Various tests were mislabeld, setvaluetests and mousewheel tests were under the "arrowbutton" group, etc.

Refs #7681

[bill]

(In [20446]) Split dijit tests into separate module.js file for each category (form, layout, tree, etc.). Not sure I like having so many files named "module.js" but following the pattern from editor/module.js. Refs #7681.

[bill]

(In [20558]) Remove redundant tests, fixing code formatting, avoiding multiple test groups with same name. Refs #7681.

[bill]

(In [20559]) Avoid "already called" error on IE8, just needed to increase timeout. Refs #7681.

[bill]

(In [20571]) Oops, file got corrupted in [20114] since it's not UTF-8. Refs #7681

[bill]

(In [20581]) Avoid "already called" error on IE8, just needed to increase timeout. Refs #7681.

[bill]

(In [20668]) More fixes to get tests working consistently. It's unfortunate that there's no way to schedule a DOH robot event after typeKeys() finishes (You can only schedule as an offset from the time it's supposed to finish, assuming that timers all fire on time) Refs #7681.

[bill]

(In [20688]) Throttle typematic at 10ms, to avoid DOH robot starvation problem hanging Spinner_mouse.html on IE8. Refs #7681 !strict

[bill]

(In [20716]) ColorPalette? automated tests (refs #7681).

[bill]

(In [20720]) Set svn:eol-style to native, refs #7681.

[bill]

(In [20725]) TitlePane? automated tests (refs #7681). Also some small updates to ColorPalette? tests.

[bill]

(In [20765]) Remove some unneeded <script> tags, refs #7681, sort-of.

[Douglas Hays]

(In [20779]) Refs #7681. Slow down automated tests to work better with VM environments.

[bill]

(In [20795]) Toolbar automated tests, refs #7681. Added some id's into ComboButton sub-nodes just to make it easier to write robot tests.

[bill]

(In [20802]) fix typo, refs #7681.

[Douglas Hays]

(In [20809]) References #7681. Tweak more robot test timings to work on FF 3.5/WinXP (slow machine).

[bill]

(In [20811]) fix typo, refs #7681.

[bill]

(In [20821]) Improved ColorPalette tests (better tab order testing and added nls testing), refs #7681 !strict.

[Douglas Hays]

(In [20828]) Refs #7681. Tweak test_scroll.html to work inside the DOH runner using IE6.

[Douglas Hays]

(In [20834]) Refs #7681. Tweak Spinner automated test timing to work better on IE6 and reinstate Mac HOME/END Spinner test.

[bill]

(In [20869]) ContentPaneLayout.html needs more than 30s to run. Refs #7681.

[Douglas Hays]

(In [21045]) Refs #7681. Tweak test_scroll.html to work with Windows XP style scrollbar sizes using IE6 & 7.

[bill]

(In [21761]) more maintainable way to test initial state, refs #7681.

[bill]

(In [21772]) fix IE6 robot test problem, refs #7681

[bill]

(In [22221]) Avoid occasional test failure when content is slow to load, refs #7681.

[bill]

(In [22711]) fix typo causing intermittent failures, and improve log message for those failures, refs #7681

[bill]

(In [22716]) Avoid spurious test failure when there's nothing in the system clipboard. Refs #7681.

[bill]

(In [22970]) Added support for holding down the META key by itself. Forced mouseMove to stay within upper-left bound of window to prevent it from spuriously aborting tests.

Patch from Mark Hays (IBM, CCLA), thanks! Hope I compiled the jar correctly (it's working for me, and the Tree DnD tests are now running correctly on mac FF).

Refs #7681, #11685.

[bill]

(In [22971]) Oh, Mark attached DOHRobot.jar to #7681, so using that one. Refs #7681, #11685.

[Douglas Hays]

(In [23023]) Refs #7681. Proxy commit for haysmark (CCLA). Fix test failures that occur more-or-less randomly.

[Douglas Hays]

(In [23080]) Refs #7681. Add focus event handling to Spinner robot tests to increase speed and reduce random timing failures.

[bill]

(In [23082]) Proper way to test that Editors have finished loading, refs #7681 (specifically [23023]).

[bill]

(In [23084]) dijit.dijit is not needed on robot control pages, but rather just on the controlled pages (i.e. the pages loaded through doh.robot.initRobot()).

Plus, requiring dijit.dijit causes "_destroyed is not an object" errors on page unload on IE, when dijit tries to destroy all widgets. dijit.findWidgets() is returning [null] rather than [] for some reason.

Refs #7681.

[bill]

(In [23086]) Wait for Textarea widgets to size themselves... it's done on a setTimeout(func, 0). Refs #7681.

[Douglas Hays]

(In [23087]) Refs #7681. Tweaks for Select.html: preload dropdown menus to reduce random test timing issues, speed up mouse moves, stop mousemove events from selecting text when the mouse button is still down (manifests especially in IE).

[Douglas Hays]

(In [23088]) Refs #7681. Replace some timing sensitive robot tests in Menu_mouse.html with event-driven segments to eliminate seemingly random IE test failures.

[Jared Jurkiewicz]

(In [23090]) Update Ally tests slightly to fix errors thrown on Windows. refs #7681

[Jared Jurkiewicz]

(In [23091]) Update Ally tests slightly to fix errors thrown on Windows. refs #7681

[Jared Jurkiewicz]

(In [23092]) Update Ally tests slightly to fix errors thrown on Windows, better normalization. refs #7681

[Douglas Hays]

(In [23093]) Refs #7681. Replace some timing sensitive robot tests in InlineEditBox?.html with event-driven segments to eliminate seemingly random IE test failures (including Already Called exceptions).

[bill]

(In [23097]) Missing parens causes test timeout, at least on IE8. Refs #7681.

[bill]

(In [23101]) Fix code to wait for Textarea widgets to size themselves... Refs #7681.

[Douglas Hays]

(In [23102]) Refs #7681. Slow down robot/Textarea.html's typing speed to work more consistently.

[Douglas Hays]

(In [23121]) Refs #7681. Add more event handlers to robot/Textarea.html so that it works better with really slow machines.

[Douglas Hays]

(In [23122]) Refs #7681. Change table variable name to make IE7 happier.

[bill]

(In [23128]) Give time for trees to initialize, refs #7681.

[Douglas Hays]

(In [23132]) Refs #7681. Start tree test with a consistent expansion state.

[Douglas Hays]

(In [23136]) Refs #7681. Fix timing problems in Form.html by calling submit() after "return d", and connect to onChange instead of _onBlur in robot/ValidationTextBox.html to avoid race.

[Douglas Hays]

(In [23140]) Refs #7681. Change ValidationMessages?.html delays from 150 to 250ms so they work on a really slow machine.

[Douglas Hays]

(In [23186]) Refs #7681. Add more events and less randomm delays to ValidationState?.html and ValidationMessages?.html to reduce both test size and time and to eliminate random failures.

[Douglas Hays]

(In [23236]) Refs #7681. Replace delays with event handlers in AccordionContainer_mouse tests to reduce random failures.

[Douglas Hays]

(In [23256]) Refs #7681. Replace dojo.xhrGet with dojo.global.dojo.xhrGet so that FF uses the right context from AccordionContainer_mouse.html.

[Douglas Hays]

(In [23258]) Refs #7681. Add some events to ProgressBar?.html to speed up the test and to reduce random failures.

[Douglas Hays]

(In [23261]) Refs #7681. Slow typing down just a bit in Editor_a11y to reduce timing failures in safari.

[bill]

(In [23262]) There's no reason for the ProgressBar DOH test to use robot because ProgressBar doesn't have any user interaction. Merging tests/test_ProgressBar.html and tests/robot/ProgressBar.html into a single tests/ProgressBar.html file.

Also, use dojo.hasClass() instead of custom code.

A lot of these tests are redundant; they aren't testing ProgressBar but merely the test page itself. I'll remove them in the next check in.

Refs #7681.

[bill]

(In [23263]) Removing some of the redundant tests. Refs #7681.

[Douglas Hays]

(In [23269]) Refs #7681. Tweak robot test timings to work better with slow FF3.6 VM.

[Douglas Hays]

(In [23334]) Refs #7681. Tweak Tree_dnd to work consistently with Chrome.

[Douglas Hays]

(In [23352]) Refs #7681. Slow-down mouse-text selection to make Chrome work more consistently.

[haysmark]

Refs #7681. Reduce test timeout from 1 day to 30 minutes.

[Douglas Hays]

(In [23360]) Refs #7681. Change test file timeouts from 27 hours to 16 minutes since WebKit? has been randomly hanging.

[Douglas Hays]

(In [23408]) Refs #7681. Tweak robot/typematic.html test to get the input value before the typematic release in order to reduce timing differences on slow machines.

[Douglas Hays]

(In [23418]) Refs #7681. Tweaked drag/scrolling test logic to work with a very small browser window to eliminate a failure on Chrome. Also changed the setup method to fire as soon as the tree is loaded instead after a random 5 seconds.

[Douglas Hays]

(In [23470]) Refs #7681. Slow down form submits to workaround IE timing problem.

[Douglas Hays]

(In [23471]) Refs #7681. Workaround no keyup event sent for meta+RightArrow? in safari/mac.

[Douglas Hays]

(In [23473]) Refs #7681. Tweak timing of Tree_v1 test to work with Chrome on a slow machine and change Tree_dnd to scroll correctly during drag on a short test client area.

[bill]

(In [23474]) Intermediate check-in to combine href loading tests for StackContainer, TabContainer, and AccordionContainer, and to eliminate the timing issues in TabContainer-remote.html. !

ContentPane?.html still has timing issues. The problem is that getResponse.php?delay=1000 can take up to 5 seconds to return.

Refs #7681.

[bill]

(In [23475]) Moving all ContentPane href loading tests into one file, and fixing numerous timing issues.

Refs #7681.

[Douglas Hays]

(In [23478]) Refs #7681. Calendar_a11y would not run in a multi-tabbed environment on Chrome since browser focus was being lost due to ctrl+page up/down being reserved by Chrome. Also, the test was trying to run without a .html extension.

[Douglas Hays]

(In [23479]) Refs #7681. Workaround tree_dnd_multiparent screen jitter problems during mousemove that was causing random failures on Chrome.

[Douglas Hays]

(In [23493]) Refs #7681. Tweak popup.html robot test to try and remove random timing failures on a slow machine.

[Douglas Hays]

(In [23504]) Refs #7681. Slow down Tree_v1 test so that menus close before trying to collapse the tree node covered by the menu.

[Douglas Hays]

(In [23510]) Refs #7681. Tweak to Tree_DND_multiParent robot test to allow for dnd/screen autoscrolling when dragging at the very bottom of the client area.

[Douglas Hays]

(In [23565]) Refs #7681. Tweak mouse movement in robot/Tree_dnd.html to account for browser rendering differences to fix test failures in IE8.

[Douglas Hays]

(In [23566]) Refs #7681. Slow down drag test in robot/BorderContainer_complex to fix random test failure with IE8.

[bill]

(In [23874]) Get tests running on IE6 and IE7, refs #7681 !strict.

[bill]

(In [23883]) Trying to eliminate more timing race conditions, hopefully will fix nightly safari5/win run. Refs #7681.

[bill]

(In [23942]) small cleanup, refs #7681

[bill]

(In [24052]) Allow async tests to return any object supporting the Deferred API, not just a doh.Deferred, fixes #12463, refs #7681 ([23082]), !strict.

[Douglas Hays]

(In [24174]) Refs #7681. Slow InlineEditBox? test down by waiting for the editor's _onFocus instead of just postCreate.

[Douglas Hays]

(In [24176]) Refs #7681. Fix some Button test/timing problems on a FF4 machine.

[Douglas Hays]

(In [24177]) Refs #7681. More Button timing problems.

[Douglas Hays]

(In [24180]) Refs #7681. Tweak timing of Form_onSubmit.html and added onChange event handler to better manage submit test speeds.

[Douglas Hays]

(In [24183]) Refs #7681. BorderContainer_complex calculations were wrong when run on a narrow browser window.

[Douglas Hays]

(In [24187]) Refs #7681. Small timing change to InlineEditBox?.html test.

[Douglas Hays]

(In [24190]) Refs #7681. IE9 had problems with simple new widget().placeAt when run in the robot's iframe.

[bill]

(In [25102]) no need for dojo.global.dijit to get the dijit in the loaded page, just accessing dijit works fine, refs #7681

[bill]

(In [25270]) avoid spurious failures, refs #7681

[bill]

(In [25303]) runTests.html for dijit/tests/_base, refs #7681

[bill]

In [26041]:

Trying to fix intermittent failures on IE8. typeKeys()'s timing is unreliable when typing more than one key. Refs #7681.

[bill]

In [26204]:

On chrome, ctrl-pagedown / ctrl-pageup switch browser tabs, so need to use alt-pagedown / alt-pageup to get to the Calendar. Refs #7681.

[bill]

In [26548]:

avoid spurious test failure on IE8 and possibly other browsers, refs #7681

[bill]

In [26951]:

Avoid "already called error!", plus other test cleanup. Apparently _onShow() was getting called twice. Refs #7681.

[bill]

In [27006]:

Try to avoid spurious timeout on IE8, refs #7681.

[bill]

In [27052]:

no reason for popup test to be a robot test, refs #7681.

[bill]

In [27130]:

[24328] erased changes from [24052], putting them back into trunk/, refs #12463, #7681, #14322 !strict.

[bill]

In [27131]:

[24328] erased changes from [24052], putting them back into 1.7/ branch, refs #12463, #7681, #14322 !strict.

[bill]

In [27385]:

fixing spelling, spacing, etc, refs #7681.

[bill]

In [27386]:

tabbing fixes, refs #7681.

[bill]

In [27567]:

make hint text within a test unique, refs #7681

[bill]

In [27717]:

trying to avoid spurious timing error, refs #7681

[bill]

In [27789]:

Wrap non-final setTimeout() callbacks in d.getTestErrback(), just in case something fails, refs #7681 and [23093].

[bill]

In [27792]:

trying to avoid spurious timing failures, refs #7681

[bill]

In [27922]:

fix timing problem on FF10, refs #7681

[bill]

In [28284]:

Close german drop down Calenda so we can focus the american DateTextBox <input>, refs #7681.

[bill]

In [29362]:

prevent spurious error to console, refs #7681

[bill]

In [29503]:

more test fixes to avoid spurious failures, refs #7681 on trunk/

[bill]

In [29504]:

more test fixes to avoid spurious failures, refs #7681 on 1.8/ branch

[haysmark]

In [29524]:

Fix for ButtonList?.html; hopefully gets us closer to a pattern we should be using for AMD robot tests. Refs #12740, #7681.

[haysmark]

In [29676]:

Update mobile tests to remove errors seen even when running on desktop. Refs #7681.

[haysmark]

In [29757]:

Fix more mobile tests. Refs #7681.

[bill]

In [29987]:

fix spelling, refs #7681

[bill]

In [29991]:

Fix various errors in TimeTextBox test, in particular that you can't have any robot commands after a d.getTestCallback(), refs #7681. Test is still flaky though.

[bill]

In [30059]:

increase timeout a bit, refs #7681

[bill]

In [30667]:

increase timeout, refs #7681

[bill]

In [30675]:

use dijit/tests/helpers::waitForLoad rather than duplicating code, refs #7681

[bill]

In [30876]:

Use proper API to set widget value, although clearing the value of a number widget requires setting it to NaN which is a bit strange. Refs #7681.

[bill]

In [31135]:

fix typo, refs #7681

[Colin Snover <github.com@…>]

In 2070514b8ad48c9308c6d76c4b81051e1e5daf34/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In 5463f819fa5c2779f56affcaf8b4815985aa7eae/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In 9cf86295113c6ed9cb2ba8fcf34def861356929b/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In f8c5154cff8417c052686d1855acb3522109e895/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[bill]

I don't think we need a meta-ticket for this anymore. If anything, in the future we'll switch to webdriver, and that surely deserves a new ticket.

[Bill Keese <bill@…>]

In 22e1395411ee81d1c6cd72bc08ef954591bb3563/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?