Opened 12 years ago

Closed 12 years ago

#7679 closed defect (fixed)

DataGrid: rtl column sizing is broken

Reported by: Adam Peller Owned by: Bryan Forbes
Priority: high Milestone: 1.2
Component: DojoX Grid Version: 1.2beta
Keywords: bidi Cc: benschell, Nathan Toone
Blocked By: Blocking:

Description

the div used for column sizing floats to the right and has a left offset equal to the width of the screen, throwing off all of the calculations. There may be other problems on top of that. See test_grid_rtl.html

Attachments (1)

gridrtl.patch​ (3.6 KB) - added by Adam Peller 12 years ago.
patch to set moverDiv to left:0 to make Moveable sane in rtl. Is this the right fix?

Download all attachments as: .zip

Change History (9)

comment:1 Changed 12 years ago by bill

Milestone: tbd → 1.3

marking these TBD tickets for 1.3 for now, although Bryan may recategorize

Changed 12 years ago by Adam Peller

Attachment: gridrtl.patch​ added

patch to set moverDiv to left:0 to make Moveable sane in rtl. Is this the right fix?

comment:2 Changed 12 years ago by Adam Peller

Milestone: 1.3 → 1.2

I'd like to apply at least a partial patch in 1.2

comment:3 Changed 12 years ago by Adam Peller

Cc: Nathan Toone added

comment:4 Changed 12 years ago by Adam Peller

(In [15284]) Set left:0 on the moveable div to fix rtl. Refs #7679 !strict

comment:5 Changed 12 years ago by Adam Peller

Milestone: 1.2 → 1.3

Column resizing is still quirky, but probably no worse than the old grid.

comment:6 Changed 12 years ago by Adam Peller

(In [15288]) One more dashed reference in the base css. Fixes #7674 And remove a negative x placement. Refs #7679

comment:7 Changed 12 years ago by Nathan Toone

(In [15298]) Fixes #7686 Refs #7679 add position="absolute" to the mover div style !strict

comment:8 Changed 12 years ago by Adam Peller

Milestone: 1.3 → 1.2
Resolution: → fixed
Status: new → closed

some other column resizing problems, predating the new DataGrid?, are described in #5978

Note: See TracTickets for help on using tickets.