Opened 11 years ago
Closed 10 years ago
#7677 closed defect (fixed)
[patch] [ccla] pageup and pagedown are not working correctly to move through data
| Reported by: | Becky Gibson | Owned by: | Bryan Forbes |
|---|---|---|---|
| Priority: | high | Milestone: | 1.3 |
| Component: | DojoX Grid | Version: | 1.2beta |
| Keywords: | a11y keyboard | Cc: | Joseph Scheuhammer |
| Blocked By: | Blocking: |
Description
using dojox/grid/tests/test_keyboard.html or test_data_grid.html the pageup and pagedown key do not work properly.
In test_keyboard.html put focus in the first cell in the grid (column 1 row 1). Press the pagedown key. The grid rows are scrolled and focus remains on a cell. Press pagedown again, the grid is again properly scrolled and focus remains on a cell. Press pagedown a third time and it appears that additional data is loaded into the grid. However, the focus is no longer on a cell but on the grid itself. Pressing the up or down arrow will now scroll the grid but there is no focus on any cell.
Attachments (2)
Change History (9)
comment:1 Changed 11 years ago by
| Milestone: | tbd → 1.3 |
|---|
Changed 11 years ago by
| Attachment: | 7677.patch added |
|---|
Patch from Poornima Trikkur (IBM CCLA): Used publish/subscribe to fix this. Subscribed the the method that renders the focus to a topic and published it once the data is rendered properly. Also made sure the focus doesnt disappear after the last row.
comment:2 Changed 10 years ago by
| Summary: | pageup and pagedown are not working correctly to move through data → [patch][ccla]pageup and pagedown are not working correctly to move through data |
|---|
comment:3 follow-up: 4 Changed 10 years ago by
| Summary: | [patch][ccla]pageup and pagedown are not working correctly to move through data → pageup and pagedown are not working correctly to move through data |
|---|
patch is not complete so removing [patch][ccla]
comment:4 Changed 10 years ago by
Replying to becky:
patch is not complete so removing [patch][ccla]
Aside from the global function definition, can you provide any analysis on what is incomplete or broken about this patch? Is this something someone might be able pick up and fix, or is it completely invalid?
comment:5 Changed 10 years ago by
| Priority: | normal → high |
|---|
Changed 10 years ago by
| Attachment: | 7677bg.patch added |
|---|
comment:6 Changed 10 years ago by
| Summary: | pageup and pagedown are not working correctly to move through data → [patch] [ccla] pageup and pagedown are not working correctly to move through data |
|---|
created patch 7677bg.patch. It is a bit of a hack as it repeats some of the focus code. See what you think. I Created FocusManager?._delayedCellFocus and connected to DataGrid?._onFetchComplete to reset focus to the cell after rendering has been completed. I thought this would also fix #7676 - it does for the pagedown key but not for arrow down.
marking these TBD tickets for 1.3 for now, although Bryan may recategorize