Opened 11 years ago

Closed 11 years ago

#7632 closed defect (fixed)

[regression] editor: indent button is never enabled

Reported by: Becky Gibson Owned by: liucougar
Priority: high Milestone: 1.2
Component: Editor Version: 1.2beta
Keywords: Cc:
Blocked By: Blocking:

Description

I used to be able to use the indent button to indent list items but now the indent button is never enabled.

run dijit/tests/test_Editor.html select all of the text in the first editor an delete it click on the bullet list button create three bullets:

  • one
  • two
  • three

put the cursor at the beginning of two. Click the indent button - note that it is marked as unavailable and clicking it does nothing. I should be able to indent an existing list item

Change History (5)

comment:1 Changed 11 years ago by Douglas Hays

This seems related to the change for #6408 / [13262]

comment:2 Changed 11 years ago by Douglas Hays

Component: DijitEditor
Owner: set to liucougar

comment:3 Changed 11 years ago by bill

Milestone: tbd1.2
Priority: normalhigh
Summary: editor: indent button is never enabled[regression] editor: indent button is never enabled

comment:4 Changed 11 years ago by Becky Gibson

adding a return in richtext._sCall() seems to fix this - can anyone think of any consequences to adding the return? This used to work even after the [13262] changes.

comment:5 Changed 11 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

(In [15244]) fixes #7632. When _sCall() was added as a wrapper to dojo.withGlobal() the return was neglected. Some callers rely on the return value to set a variable. That was the case for indent. Solution was add a return to sCall().

Note: See TracTickets for help on using tickets.