Changes between Initial Version and Version 3 of Ticket #7630


Ignore:
Timestamp:
Sep 10, 2008, 2:27:27 AM (11 years ago)
Author:
bill
Comment:

Replying to doughays:

(In [15194]) Fixes #7630. Removed the short-circuit case for a blank displayed value that precluded this situation.

Hmm, the code removed in this checkin was intentionally added in [15118] as part of #5974, to

  • prevent a bunch of spurious requests to the data store on page load (a performance issue for remote data stores)
  • to work around a data store's bug/behavior where a query on "" returned all items instead of the single item with value=""

Albeit, it only half-fixes the performance issue since FilteringSelect will still ping a data store any time the value != "".

Note that the text in the ticket description is inaccucurate:

When the combo box contains an item that is blank it is not recognized as legal

Assuming that you haven't specified required=true, a blank <input> is considered legal. It's just that you can't specify a mapping from a blank display value to a value like -1. IE, blank values in the data store aren't supported.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7630

    • Property Status changed from new to closed
    • Property Summary changed from Bug in dijit.form.FilteringSelect . Empty or space in display Value is not legal to FilteringSelect: can't map empty label to value
    • Property Resolution changed from to fixed
    • Property Milestone changed from tbd to 1.2
  • Ticket #7630 – Description

    initial v3  
    55This behavior is new.
    66
    7 
    8 
    97Correct and desired behavior: the set attribute 'value' must be returned, even if displayed value is empty.
    108
    11 See attache show case:
     9See attached show case:
    1210
    1311Replication:
    1412
    15 [1] in on button clickme.
    16 [2] dialog with combo will be displayed (default value=-1, displayed value: ''.
    17 
    18 [3] click on dialog, yellow color will be displayed (not valid)
    19 
    20 [4] click ok for any other item or for the last (the value:-1 item)
     13 1. in on button clickme.
     14 2. dialog with combo will be displayed (default value=-1, displayed value: blank)
     15 3. click on dialog, yellow color will be displayed (not valid)
     16 4. click ok for any other item or for the last (the value:-1 item)
    2117
    2218