Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7563 closed defect (fixed)

[patch][ccla] dojox.storage: put/get/deleteMultiple batch actions fixed

Reported by: Adam Peller Owned by: bradneuberg
Priority: high Milestone: 1.2
Component: Storage/Flash Version: 1.2beta
Keywords: Cc: jcerruti@…
Blocked By: Blocking:

Description

There are several simple bugs where put/get/deleteMultiple don't work. Probably where there from the beginning and went unnoticed b/c nobody used these functions.

Concretely the errors are:

  • Missing 'this' qualifier to reference the namespace (FlashStorageProvider?.js)
  • Missing 'this' context object in dojo.some call (Provider.js -> isValidKeysArray)

Included is a patch for these problems and also, in order to help avoid this sort of issue in the future, a set of additions to the storage test cases to allow testing this feature with the different providers.

Note that these won't work in the Flash storage provider until the patch for the dojox.flash interface has been applied (see tracker item #7562)

Attachments (1)

dojox.storage-multiple.diff (7.8 KB) - added by Adam Peller 11 years ago.
patch from Julian Cerruti (IBM)

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by Adam Peller

Attachment: dojox.storage-multiple.diff added

patch from Julian Cerruti (IBM)

comment:1 Changed 11 years ago by Adam Peller

Component: DojoxStorage/Flash

comment:2 Changed 11 years ago by Brad Neuberg

Resolution: fixed
Status: newclosed

(In [15191]) Fixes #7563; also fixed some bugs new test cases shook out in put/get multiple functionality

comment:3 Changed 11 years ago by Brad Neuberg

I applied this patch and tested its functionality across the three providers (Gears, Flash, WhatWG) across Google Chrome, FF 3, IE 7, and Safari. This shook out some bugs that I also fixed. I'd like to get test coverage of the multiple remove functionality as well; I'm going to close this bug and open a new one to track creating test coverage for multiple remove. Julian, can you create a test case for that one? I'll add you on the bug.

comment:4 Changed 11 years ago by Brad Neuberg

Created #7626 to track creating test case for removeMultiple functionality.

comment:5 Changed 11 years ago by Brad Neuberg

Version: 1.1.11.2beta
Note: See TracTickets for help on using tickets.