#7563 closed defect (fixed)
[patch][ccla] dojox.storage: put/get/deleteMultiple batch actions fixed
Reported by: | Adam Peller | Owned by: | bradneuberg |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Storage/Flash | Version: | 1.2beta |
Keywords: | Cc: | [email protected]… | |
Blocked By: | Blocking: |
Description
There are several simple bugs where put/get/deleteMultiple don't work. Probably where there from the beginning and went unnoticed b/c nobody used these functions.
Concretely the errors are:
- Missing 'this' qualifier to reference the namespace (FlashStorageProvider?.js)
- Missing 'this' context object in dojo.some call (Provider.js -> isValidKeysArray)
Included is a patch for these problems and also, in order to help avoid this sort of issue in the future, a set of additions to the storage test cases to allow testing this feature with the different providers.
Note that these won't work in the Flash storage provider until the patch for the dojox.flash interface has been applied (see tracker item #7562)
Attachments (1)
Change History (6)
Changed 12 years ago by
Attachment: | dojox.storage-multiple.diff added |
---|
comment:1 Changed 12 years ago by
Component: | Dojox → Storage/Flash |
---|
comment:2 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 12 years ago by
I applied this patch and tested its functionality across the three providers (Gears, Flash, WhatWG) across Google Chrome, FF 3, IE 7, and Safari. This shook out some bugs that I also fixed. I'd like to get test coverage of the multiple remove functionality as well; I'm going to close this bug and open a new one to track creating test coverage for multiple remove. Julian, can you create a test case for that one? I'll add you on the bug.
comment:4 Changed 12 years ago by
Created #7626 to track creating test case for removeMultiple functionality.
comment:5 Changed 12 years ago by
Version: | 1.1.1 → 1.2beta |
---|
patch from Julian Cerruti (IBM)