Opened 11 years ago

Closed 11 years ago

#7561 closed defect (worksforme)

[patch][ccla] Flash object created multiple times

Reported by: Adam Peller Owned by: bradneuberg
Priority: high Milestone: 1.2
Component: Storage/Flash Version: 1.1.1
Keywords: Cc: jcerruti@…
Blocked By: Blocking:

Description

When there is one more layer in the build project - or even under certain difficult to reproduce circumstances in source mode or in built mode with a single layer, the dojox.flash interface incorrectly creates more than one flash object for any given Flash file that should be created.

This problem appears because the dojox.flash interface doesn't seem to take into account dojo.addOnLoad could now be called more than once (once per layer) instead of a single time in the entire application's lifetime

Attached is a simple patch that resolves this problem.

Attachments (1)

dojox.flash-duplicate.diff (1.3 KB) - added by Adam Peller 11 years ago.
patch from Julian Cerruti (IBM)

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by Adam Peller

Attachment: dojox.flash-duplicate.diff added

patch from Julian Cerruti (IBM)

comment:1 Changed 11 years ago by Adam Peller

Cc: jcerruti@… added
Owner: changed from Brad Neuberg to bradneuberg

comment:2 Changed 11 years ago by Adam Peller

Component: DojoxStorage/Flash

comment:3 Changed 11 years ago by Brad Neuberg

Hi Adam, I was about to apply this patch when I noticed that the patch you sent me differs a bit from what I have in SVN. Over in the connect callback for the onload event, I put the following at the top of the callback awhile back:

Prevent putting duplicate SWFs onto the page

var containerId = this.id + "Container"; if(dojo.byId(containerId)){

return;

}

Do you not have this code in your version? When applied, does that prevent the bug? I don't have a repeatable way to test this bug so can't tell. Do you have any steps on how to reproduce it myself? If that code doesn't work then I'll apply the patch you sent.

comment:4 Changed 11 years ago by jcerruti

It does look as if this would solve the problem effectively. Our patches where all done against 1.1 - thought I do recall looking for anything that would fix it in trunk ... maybe I missed it? Sorry about that.

I'll try to verify the problem doesn't happen against trunk. I think our code is intricate enough that it won't be hard to reproduce the rror.

Thanks for the attention.

comment:5 Changed 11 years ago by Brad Neuberg

Unless Julian finds that the existing patch doesn't fix this, this is a WONTFIX bug. Keeping it open until Julian has tested what's in the 1.2 SVN against his testing environment.

comment:6 Changed 11 years ago by jcerruti

I can confirm the original fix by Brad. W/o that fix we get two flash objects, with the original fix there's only one flash object again.

comment:7 Changed 11 years ago by Brad Neuberg

Resolution: worksforme
Status: newclosed

Thanks for all your help and patches Julian! Closing bug.

Note: See TracTickets for help on using tickets.