Remove unnecessary code

[Eugene Lazutkin]

Due to fixing bugs in dojo.place(), the explicit use of the default parameter is not required anymore. Following snippet from the beginning of dijit._Container.addChild() can be safely removed:

if(insertIndex === undefined){
  insertIndex = "last";
}

[Eugene Lazutkin]

The corresponding ticket for Dojo Core is #7547.

[Eugene Lazutkin]

Correction: the corresponding ticket for Dojo Core is #7546.

[bill]

Seems like we can get rid of the next block too:

			var refNode = this.containerNode;
			if(insertIndex && typeof insertIndex == "number"){
				var children = dojo.query("> [widgetId]", refNode);
				if(children && children.length >= insertIndex){
					refNode = children[insertIndex-1];
					insertIndex = "after";
				}
			}

[Eugene Lazutkin]

I am not so sure. dojo.placw works with all node's children, while this snippet works only with children that have "widgetId" attribute set. Please verify that removing this condition will not break the function.

[bill]

Hmm, good point. In general all child nodes of this.containerNode are widgets, but I suppose that's not guaranteed (although I notice that getNextSibling() / getPreviousSibling() will break if that isn't the case).

I'll just remove those three lines for now.

[bill]

(In [14991]) Remove unnecessary code, fixes #7547.