Opened 11 years ago

Closed 11 years ago

#7541 closed defect (fixed)

[PATCH] [CCLA] The sortFields option of DataGrid does not appear to work anymore

Reported by: Jared Jurkiewicz Owned by: Nathan Toone
Priority: high Milestone: 1.4
Component: DojoX Grid Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

The sortFields option of DataGrid? does not appear to work anymore

In earlier versions of the 1.2 grid, sortFields values would work as initial sorting information on the new DataGrid?, which kept compatibility to the old model's sortFields. In the current 1.2 extract, it doesn't work anymore. This can be seen in test:

http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/data/demos/demo_FileStore_dojoxdata_combo_grid.html

It used to sort by path on its initial load, now it doesn't.

Clicking on the fields does sort, though, so sorting in grid works. It just appears to be ignoring initial sort details.

Attachments (1)

dojoxGrid_sortFields_20090213.patch (623 bytes) - added by Jared Jurkiewicz 11 years ago.
Tweak to re-enable specifying an initial sorting in grid.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 11 years ago by bill

Milestone: tbd1.3

marking these TBD tickets for 1.3 for now, although Bryan may recategorize

comment:2 Changed 11 years ago by Bryan Forbes

Milestone: 1.31.2

comment:3 Changed 11 years ago by Bryan Forbes

Milestone: 1.21.3

comment:4 Changed 11 years ago by Nathan Toone

Owner: changed from Bryan Forbes to Nathan Toone

Reassigning to me

comment:5 Changed 11 years ago by Nathan Toone

Milestone: 1.3future

comment:6 Changed 11 years ago by Jared Jurkiewicz

Re-enabling an 'initial sort' capability in terms of ordering is a trivial thing to add (I looked in the DataGrid? code and found exactly what had to be tweaked to get this function back (the compat grid has it). Simple patch follows. I'm not sure if this is exactly how you want to do it (the name of the field is sortFields) and directly translates down to the sort array of the store, but anyway. its a start:

Changed 11 years ago by Jared Jurkiewicz

Tweak to re-enable specifying an initial sorting in grid.

comment:7 Changed 11 years ago by Jared Jurkiewicz

Summary: The sortFields option of DataGrid does not appear to work anymore[PATCH] [CCLA] The sortFields option of DataGrid does not appear to work anymore

comment:8 Changed 11 years ago by Nathan Toone

Milestone: future1.4

comment:9 Changed 11 years ago by Nathan Toone

Milestone: 1.41.3.1

Fixed in trunk in [17157] - changing milestone for consideration for inclusion on branch.

comment:10 Changed 11 years ago by Nathan Toone

Milestone: 1.3.11.4
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.