Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7538 closed defect (fixed)

Gears Dojo Storage Provider should not display Gears permission dialog immediately, but rather when get() or put() operations are called

Reported by: Brad Neuberg Owned by: bradneuberg
Priority: high Milestone: 1.2
Component: Storage/Flash Version: 1.1.1
Keywords: Cc: mpirnat
Blocked By: Blocking:

Description

If you go to http://www.msn.americangreetings.com/ecards/birthday/ and have Gears installed, you will see a Gears permission dialog appear when the page loads. This is bad practice (see http://code.google.com/apis/gears/gears_faq.html#bestGearsPerms), but its not American Greetings fault, its mine. I need to modify the Gears Dojo Storage Provider to not display the prompt immediately, but to delay until a get() or put() operation is called so that the prompt appears when a user starts trying to do something that involves storage.

Change History (3)

comment:1 Changed 11 years ago by mpirnat

Awesome, looking forward to applying your patch. :-)

Luckily our userbase is, at least so far, highly unlikely to have Gears installed, so we have not been getting any reports of this from our customer service folks.

comment:2 Changed 11 years ago by Brad Neuberg

Resolution: fixed
Status: newclosed

(In [15186]) Fixes #7538; also cleaned up the code a bit around verifying keys and namespaces

comment:3 Changed 11 years ago by Adam Peller

Milestone: tbd1.2
Note: See TracTickets for help on using tickets.