[patch][ccla] Storage.swf gets 404 trying to retrieve storage_dialog.swf in IE

[mpirnat]

dojox.flash._base doesn't seem to pass a baseUrl parameter to the object tag generated for IE in non-express-install instances. This causes DojoExternalInterface?.getDojoPath to mangle and incorrectly set the Dojo base URL inside the Storage swf. This in turn causes Storage.swf's request for storage_dialog.swf to point to a bad URL that will always 404.

Here's an example that I captured internally -- note the absence of baseUrl in the request for Storage.swf, and the resulting nasty request for storage_dialog.swf:

GET ​http://stage.imgag.com/js/built/ag/dojox/storage/Storage.swf?cachebust=1217891534169&xdomain=http%3A//stage.americangreetings.com 200 OK

GET ​http://stage.americangreetings.com/ecards/stage.imgag.com/js/built/ag/dojox/storage/Storage.swf?cachebust=1217891534169storage_dialog.swf 404 Not Found

Additionally, the DojoExternalInterface? side needs to unescape the baseUrl so that we don't end up making partially URL-encoded requests -- ie, probably no good to make requests that start with "http%3A".

We (American Greetings) have a CCLA on file, so I've attached our patch.

[Brad Neuberg]

Thanks for this patch; I will apply it soon. I will also fix bug #7538 which affects American Greetings as well. Thanks for using Dojo Storage!

[Brad Neuberg]

(In [15183]) Fixes #7532