Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7532 closed defect (fixed)

[patch][ccla] Storage.swf gets 404 trying to retrieve storage_dialog.swf in IE

Reported by: mpirnat Owned by: bradneuberg
Priority: high Milestone: 1.2
Component: Storage/Flash Version: 1.1.1
Keywords: Cc: mpirnat@…
Blocked By: Blocking:

Description

dojox.flash._base doesn't seem to pass a baseUrl parameter to the object tag generated for IE in non-express-install instances. This causes DojoExternalInterface?.getDojoPath to mangle and incorrectly set the Dojo base URL inside the Storage swf. This in turn causes Storage.swf's request for storage_dialog.swf to point to a bad URL that will always 404.

Here's an example that I captured internally -- note the absence of baseUrl in the request for Storage.swf, and the resulting nasty request for storage_dialog.swf:

GET http://stage.imgag.com/js/built/ag/dojox/storage/Storage.swf?cachebust=1217891534169&xdomain=http%3A//stage.americangreetings.com 200 OK

GET http://stage.americangreetings.com/ecards/stage.imgag.com/js/built/ag/dojox/storage/Storage.swf?cachebust=1217891534169storage_dialog.swf 404 Not Found

Additionally, the DojoExternalInterface? side needs to unescape the baseUrl so that we don't end up making partially URL-encoded requests -- ie, probably no good to make requests that start with "http%3A".

We (American Greetings) have a CCLA on file, so I've attached our patch.

Attachments (1)

storage_dialog.patch (1.5 KB) - added by mpirnat 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by mpirnat

Attachment: storage_dialog.patch added

comment:1 Changed 11 years ago by Brad Neuberg

Thanks for this patch; I will apply it soon. I will also fix bug #7538 which affects American Greetings as well. Thanks for using Dojo Storage!

comment:2 Changed 11 years ago by Brad Neuberg

Resolution: fixed
Status: newclosed

(In [15183]) Fixes #7532

comment:3 Changed 11 years ago by Adam Peller

Milestone: tbd1.2
Note: See TracTickets for help on using tickets.