Context Navigation

← Previous Ticket
Next Ticket →

#7518 closed defect (fixed)

Validate URL: new TLD rs

Reported by:	Goran Miskovic	Owned by:	dante
Priority:	high	Milestone:	1.2
Component:	Dojox	Version:	1.1.1
Keywords:	validate, URL, TLD, rs	Cc:
Blocked By:		Blocking:

Description

dojox.validate.isUrl is not validating TLD rs.

Since March this year new TLD "rs" has been added. TLD "yu" is going to be deleted as of September 30 2009. http://en.wikipedia.org/wiki/.rs

Resolution: In dojox.validate.regexp on line 44 between ro and ru rs should be added e.g. variable ccRE should read:

	// Country Code top-level domains RE
	var ccRE = 
		"ac|ad|ae|af|ag|ai|al|am|an|ao|aq|ar|as|at|au|aw|az|ba|bb|bd|be|bf|bg|bh|bi|bj|bm|bn|bo|br|" +
		"bs|bt|bv|bw|by|bz|ca|cc|cd|cf|cg|ch|ci|ck|cl|cm|cn|co|cr|cu|cv|cx|cy|cz|de|dj|dk|dm|do|dz|" +
		"ec|ee|eg|er|eu|es|et|fi|fj|fk|fm|fo|fr|ga|gd|ge|gf|gg|gh|gi|gl|gm|gn|gp|gq|gr|gs|gt|gu|gw|"
		+
		"gy|hk|hm|hn|hr|ht|hu|id|ie|il|im|in|io|ir|is|it|je|jm|jo|jp|ke|kg|kh|ki|km|kn|kr|kw|ky|kz|" +
		"la|lb|lc|li|lk|lr|ls|lt|lu|lv|ly|ma|mc|md|mg|mh|mk|ml|mm|mn|mo|mp|mq|mr|ms|mt|mu|mv|mw|mx|" +
		"my|mz|na|nc|ne|nf|ng|ni|nl|no|np|nr|nu|nz|om|pa|pe|pf|pg|ph|pk|pl|pm|pn|pr|ps|pt|pw|py|qa|" +
		"re|ro|rs|ru|rw|sa|sb|sc|sd|se|sg|sh|si|sk|sl|sm|sn|sr|st|su|sv|sy|sz|tc|td|tf|tg|th|tj|tk|tm|" +
		"tn|to|tr|tt|tv|tw|tz|ua|ug|uk|us|uy|uz|va|vc|ve|vg|vi|vn|vu|wf|ws|ye|yt|yu|za|zm|zw";

Change History (8)

comment:1 Changed 12 years ago by dante

Milestone:	tbd → 1.2
Owner:	changed from Adam Peller to dante

Interesting. The wikipedia article indicates both .rs and .me have been added and .yu will be removed in 2009 ... I wonder if there is a way to set a specific date on a ticket, or if yu should be left for legacy purposes?

comment:2 Changed 12 years ago by Goran Miskovic

I think that TLD "yu" must stay until September 30, 2009. After that it should be removed. I will remind you on October 1st next year. :)

I am sorry about forgetting on Montenegro. With "me" TLD added variable ccRE should read:

	// Country Code top-level domains RE
	var ccRE = 
		"ac|ad|ae|af|ag|ai|al|am|an|ao|aq|ar|as|at|au|aw|az|ba|bb|bd|be|bf|bg|bh|bi|bj|bm|bn|bo|br|" +
		"bs|bt|bv|bw|by|bz|ca|cc|cd|cf|cg|ch|ci|ck|cl|cm|cn|co|cr|cu|cv|cx|cy|cz|de|dj|dk|dm|do|dz|" +
		"ec|ee|eg|er|eu|es|et|fi|fj|fk|fm|fo|fr|ga|gd|ge|gf|gg|gh|gi|gl|gm|gn|gp|gq|gr|gs|gt|gu|gw|"
		+
		"gy|hk|hm|hn|hr|ht|hu|id|ie|il|im|in|io|ir|is|it|je|jm|jo|jp|ke|kg|kh|ki|km|kn|kr|kw|ky|kz|" +
		"la|lb|lc|li|lk|lr|ls|lt|lu|lv|ly|ma|mc|md|me|mg|mh|mk|ml|mm|mn|mo|mp|mq|mr|ms|mt|mu|mv|mw|mx|" +
		"my|mz|na|nc|ne|nf|ng|ni|nl|no|np|nr|nu|nz|om|pa|pe|pf|pg|ph|pk|pl|pm|pn|pr|ps|pt|pw|py|qa|" +
		"re|ro|rs|ru|rw|sa|sb|sc|sd|se|sg|sh|si|sk|sl|sm|sn|sr|st|su|sv|sy|sz|tc|td|tf|tg|th|tj|tk|tm|" +
		"tn|to|tr|tt|tv|tw|tz|ua|ug|uk|us|uy|uz|va|vc|ve|vg|vi|vn|vu|wf|ws|ye|yt|yu|za|zm|zw";

comment:3 Changed 12 years ago by dante

Resolution:	→ fixed
Status:	new → closed

(In [14945]) fixes #7518 - adding .rs and .me TLD's to validation regexp -- thanks for catching that! I'm holding you too reminding me in 2009 - but I put a note inline regardless.