Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7501 closed defect (fixed)

dijit.layout.ContentPane.setHref implementation is broken

Reported by: Matt Sgarlata Owned by: dante
Priority: high Milestone: 1.2
Component: Dijit Version: 1.1.1
Keywords: Cc: development-staff@…
Blocked By: Blocking:

Description

I know this method is deprecated, but it currently displays a deprecation notice and then fails to call this.attr. Here is the offending line of code (stars added for emphasis):

setHref: function(/*String|Uri*/ *href*){

dojo.deprecated("dijit.layout.ContentPane?.setHref() is deprecated. Use attr('href', ...) instead.", "", "2.0"); return this.attr("href", *data*);

}

it should be the following (stars added for emphasis)

return this.attr("href", *href*)

Change History (3)

comment:1 Changed 11 years ago by dante

Milestone: tbd1.2
Owner: set to dante
Status: newassigned

good catch. thanks.

comment:2 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

fixed in [14934] ... commit comment didn't get picked up?

comment:3 Changed 11 years ago by Matt Sgarlata

Thanks!

Note: See TracTickets for help on using tickets.