[patch][cla] dojo.query breaks for expressions like "a[href*='foo=bar']"

[ptwobrussell]

The specific error you'll get is

failure in exprssion: .//A[@href='foo='bar'']

Found this out the hard way when I was trying to use dojo.query to find a hyperlink on a page that had a href= with an equals sign in it.

None of the tests for query seemed to cover the case when you have a selector with a substring in it that contains an equals sign, so that's probably why it slipped through.

The specific issue is that the expression in the state machine on line 152 (r14546) is matching on the = sign when it shouldn't be.

I tried to generalize a good solution to this one, but admittedly haven't tested the solution extensively. It doesn't break any tests, however, and does solve this problem, so maybe it'll work. The thinking was that the simplest way to get around this edge case might be to treat it similar to the way that lexers optimize out comments in source code. i.e. ignore anything between single quotes completely since it can't be part of an actual CSS expression and should be treated as a constant of sorts.

Index: query.js
===================================================================
--- query.js	(revision 14916)
+++ query.js	(working copy)
@@ -70,6 +70,7 @@
 		var inClass = -1;
 		var inId = -1;
 		var inTag = -1;
+		var inSingleQuote = false;
 		var lc = ""; // the last character
 		var cc = ""; // the current character
 		var pStart;
@@ -122,6 +123,15 @@
 				inTag = x;
 			}
 
+            if (cc == "'" && inSingleQuote) {
+               inSingleQuote = false;
+                continue;
+            }
+            else if (cc == "'" || inSingleQuote) {
+                inSingleQuote = true;
+                continue;
+            }
+
 			if(inBrackets >= 0){
 				// look for a the close first
 				if(cc == "]"){

Cheers.

[dante]

see also #7512

[bill]

as per today's meeting, punting these core bugs

[dante]

please review and address. patch is likely stale since recent refactor, but willing to bet issue exists. can work up series of unit tests for oddball query bugs like this, if preferred.

[Chris Mitchell]

please review/triage

[ben hockey]

#8631 is a duplicate of this ticket.

[ben hockey]

#9193 is a duplicate of this ticket.

[bill]

In [27955]:

test case for attributes with equals signs, refs #7479.

[bill]

Oh, OK the bug is still there but it only triggers in IE. I will apply a modified version of your patch, thanks!

[bill]

In [27969]:

Fix for handled quoted values in IE branch of code, fixes #7479, #13084 on IE !strict. Thanks to ptwobrussell for basis of patch.

[Colin Snover]

In [30042]:

Fix for handled quoted values in IE branch of code, fixes #7479, #13084 on IE !strict. Thanks to ptwobrussell for basis of patch. Backport to 1.7