Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#7478 closed defect (fixed)

diit.form.Button: <p> around diit.form.Button breaks rendering in IE

Reported by: nonken Owned by: Douglas Hays
Priority: high Milestone: 1.2
Component: Dijit - Form Version: 1.1.1
Keywords: Button, p Cc: nonken
Blocked By: Blocking:

Description (last modified by bill)

in tests/form/test_Button.html put a <p> around a button.

<p>
<button id="1465" dojoType="dijit.form.Button" onClick='console.log("clicked simple")' iconClass="plusIcon">
Create
</button></p>

This breaks IE but shouldn't since buttons are allowed in <p> tags

Change History (6)

comment:1 Changed 11 years ago by bill

Description: modified (diff)

I was able to make this problem go away by changing all the <div> tags in the button template to <span> tags. Button still seemed to render correctly (on IE anyway) but it would need more testing.

I'm just thinking that the generated DOM, and it's surrounding nodes, are pretty strange:

<p>
   <div>
        <div>
            <button>
                 <div></div>
            </button>
       </div>
   </div>
</p>

Neither <button> nor <p> should contain <div> so it's not completely surprising that something fails.

comment:2 Changed 11 years ago by Douglas Hays

Milestone: tbd1.2
Status: newassigned

comment:3 Changed 11 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [15093]) Fixes #7478. Changed Button template div tags to spans.

comment:4 Changed 11 years ago by bill

Resolution: fixed
Status: closedreopened

Doug, can you update DropDownButton too? Presumably that has the same problem. (And maybe ComboButton too, although that's using a table)

comment:5 Changed 11 years ago by Douglas Hays

Resolution: fixed
Status: reopenedclosed

(In [15099]) Fixes #7478. Changed DropDownButton? template div tags to spans. Left ComboButton? template as-is since it uses a table tag and does not cause IE to throw an exception.

comment:6 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.