Opened 12 years ago
Closed 12 years ago
#7465 closed defect (fixed)
grid autoHeight
Reported by: | maulin | Owned by: | Nathan Toone |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | DojoX Grid | Version: | 1.1.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
if grid belongs to a parent node with height=0, then setting autoHeight=true on the markup works as expected, EXCEPT that the header row is not visible (going into firebug and changing style on header to have height=33px, makes it show up.) attached is test case.
Attachments (3)
Change History (7)
Changed 12 years ago by
Attachment: | test_data_grid_autoHeightBug.html added |
---|
comment:1 Changed 12 years ago by
Changed 12 years ago by
Attachment: | test_data_grid_autoHeightBug.2.html added |
---|
autoHeight bug where set to number > rowCount
comment:2 Changed 12 years ago by
I think I found the source: Line 587-588 of _Grid show:
Otherwise, show the header and give it an appropriate height.
this.viewsHeaderNode.style.display = "block";
but the "give it an appropritate height part is never called. I added:
Otherwise, show the header and give it an appropriate height.
this.viewsHeaderNode.style.display = "block"; this._getHeaderHeight();
and it works fine!(and yes, I have signed the CLA)
Changed 12 years ago by
Attachment: | _Grid.js.patch added |
---|
comment:3 Changed 12 years ago by
Owner: | changed from Bryan Forbes to Nathan Toone |
---|
comment:4 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
additionally, if you set autoHeight=number, where number is > than the number of rows returned, you also lose the header (though if number is < rowCount, it works as expected). I also attached a test case for that