[regression] Editor: broken in Nightly Build:17/Aug/2008

[taras]

Hi

The Editor widget was broken in 17/Aug/2008. In the 16/Aug/2008 version was OK.

Tested with the following Browsers:

FF2 : Not OK (is broken)

Safari3 : NOT OK.

IE7: Is OK '''

See standard test: dijit/tests/test_Editor.html

I attached images of the test examples on all the above browsers.

[taras]

On Firefox 2

[taras]

On Safari3

[taras]

Explorer 7

[Adam Peller]

console says this.editNode is undefined (see setDisabledAttr, RichText?.js line 747)

[Adam Peller]

looks like it might be related to [14873]

[bill]

The FF2 problem is (likely?) related to delays in initialization because of the iframe (we have setTimeout's in the code waiting for the iframe to initialize). That doesn't explain safari though.

I remember Nathan and I had discussions about whether the automatic attr() calls should occur before or after postCreate(). They are occuring before postCreate() now and that caused a few issues in other widgets (which we fixed). Moving them to after postCreate() might be better, although it might cause some other unforseen issues.

[Nathan Toone]

I think that calling it before postCreate is still OK - if someone writes custom code that depends on nodes that they themselves create during postCreate, then it should be up to them to ensure that their _setXXXAttr functions work correctly.

[Nathan Toone]

(In [14897]) Fixes #7464 - Update RichTextEditor? to handle having its _setDisabledAttr function called before the nodes have loded. We save that we had dojo.attr("disabled") called and call it again after the nodes are fully in-place.

[taras]

I am not completely sure if I need to open a new issue or reopen this, it seems to me to be related with the previous correction.

On both: Safary3 and FF2 it is impossible to write inside the textarea or choose one of the functions in the menu.

See test: dijit/tests/test_Editor.html

IE7, continues to be OK.

thanks !

Eduardo

[bill]

Relevant links:

• ​http://archive.dojotoolkit.org/dojo-2008-08-16/dojotoolkit/dijit/tests/test_Editor.html
• ​http://archive.dojotoolkit.org/dojo-2008-08-17/dojotoolkit/dijit/tests/test_Editor.html
• ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Editor.html

Looking at this briefly it seems that on safari contenteditable=false. I.e., the editors are all disabled (even though they shouldn't be).

[Nathan Toone]

Fixed in [14916]