Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7453 closed defect (fixed)

BorderContainer: splitter max is broken

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.2
Component: Dijit Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

In most of the test examples, you can drag the splitter beyond the edge of the next panel, which should not be allowed. In some cases, where there are only two panels across, you can drag it off the screen where it cannot come back.

Change History (9)

comment:1 Changed 11 years ago by Adam Peller

(In [15022]) make measurements match test. Refs #7453

comment:2 Changed 11 years ago by Adam Peller

(In [15023]) recalculate splitter constraints when opposite panel is resized. Refs #7453 !strict

comment:3 Changed 11 years ago by Adam Peller

(In [15024]) recalculate splitter constraints when flag is set. Refs #7453 !strict

comment:4 Changed 11 years ago by Adam Peller

(In [15025]) recalculate splitter constraints on resize. Refs #7453 !strict

comment:5 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [15028]) Still not perfect with borders, padding, and gutters, but it might not be worth all those measurements. Otherwise, resizing constraints seem sane now. Fixes #7453 !strict

comment:6 Changed 11 years ago by bill

Milestone: tbd1.2
Resolution: fixed
Status: closedreopened

[15028] is causing errors on page unload (tested on IE, themeTester.html).

The counterpart of this.connect() is this.disconnect(), not dojo.disconnect(), but you don't need to call this.disconnect() (or dojo.disconnect()) at all, because it's automatically called on widget destroy. Also, the third argument to this.connect() should just be a string, not a dojo.hitch() call.

comment:7 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed

(In [15029]) Remove unneeded dojo.disconnect. Fixes #7453 !strict

comment:8 Changed 11 years ago by Adam Peller

(In [15031]) Fix args to this.connect. Fixes #7453 !strict

comment:9 Changed 11 years ago by Adam Peller

(In [15113]) missing 'this'. Refs #7453, Fixes #7582 !strict

Note: See TracTickets for help on using tickets.