Opened 11 years ago

Closed 11 years ago

#7429 closed enhancement (fixed)

[patch][ccla]Highlight: API for string processing & partial result support

Reported by: Adam Peller Owned by: dante
Priority: high Milestone: 1.2
Component: Dojox Version: 1.1.1
Keywords: Cc: castanef@…
Blocked By: Blocking:

Description

submitting patch from Frank Castaneda, castanef@… (IBM)

  1. Change the highlight/_base.js to support string processing, instead of limiting it to just dom nodes.
  1. Include a way to retrieve a partial result if an error occurs parsing the language (used to display partial formatting

results).

See attached patch for suggested changes.

Attachments (1)

highlight_base.patch​ (5.8 KB) - added by Adam Peller 11 years ago.
updated patch from Frank Castaneda (IBM, CCLA) with tests and docs

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by Adam Peller

Cc: castanef@… added

comment:2 Changed 11 years ago by Adam Peller

Milestone: tbd → 1.2

comment:3 Changed 11 years ago by dante

@peller: I applied the patch locally and the two added tests fail? I checked Safari and FF3 with the same results. Got 'undefined', expected 'javascript'

Changed 11 years ago by Adam Peller

Attachment: highlight_base.patch​ added

updated patch from Frank Castaneda (IBM, CCLA) with tests and docs

comment:4 Changed 11 years ago by Adam Peller

sorry about that. patch should work this time.

comment:5 Changed 11 years ago by dante

Resolution: → fixed
Status: new → closed

(In [14965]) fixes #7429 - thanks peller for fixing unit tests - thanks frank for the patch [ccla/ibm] - plops partial string matching as additional API, leaving orig API unscathed. !strict

Note: See TracTickets for help on using tickets.