Opened 11 years ago

Closed 11 years ago

#7400 closed defect (wontfix)

[patch][no-cla] Fix base64 trailing padding removal

Reported by: rgl Owned by: Tom Trenka
Priority: high Milestone: tbd
Component: Dojox Version:
Keywords: Cc:
Blocked By: Blocking:

Description

dojox trunk base64 code is wrongly removing all NUL characters from the end of decoded data. this ticket included the unit tests that demonstrate the problem and a respective patch.

Attachments (2)

base64-tests.patch​ (1.9 KB) - added by rgl 11 years ago.
unit tests
base64-fix-trailing-padding-removal.patch​ (776 bytes) - added by rgl 11 years ago.
fix

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by rgl

Attachment: base64-tests.patch​ added

unit tests

Changed 11 years ago by rgl

Attachment: base64-fix-trailing-padding-removal.patch​ added

fix

comment:1 Changed 11 years ago by dante

Owner: changed from Adam Peller to Tom Trenka
Summary: Fix base64 trailing padding removal → [patch][no-cla] Fix base64 trailing padding removal

comment:2 Changed 11 years ago by Tom Trenka

Resolution: → wontfix
Status: new → closed

The null byte removal was deliberate and from my understanding, both part of the spec as well as needed for all of the crypto code...so I'm not even going to look at this patch (since it's no CLA) and close this as "won't fix".

Appreciate the theoretical exactness but unless I see a real use case (and after 3 years, I haven't)...

Note: See TracTickets for help on using tickets.