Opened 11 years ago

Closed 3 years ago

#7390 closed task (fixed)

[meta] style guideline adherence

Reported by: dante Owned by: dante
Priority: high Milestone: 1.11
Component: General Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

There are a lot of flubs in our own commitment to style guidelines. This meta ticket is to be used to commit small style guidelines changes. This is mostly for small nits, like spaces between if () and } else { etc.

the guidelines are defined at: http://dojotoolkit.org/developer/StyleGuide

Change History (16)

comment:1 Changed 11 years ago by dante

(In [14743]) refs #7390 - minor space and tab nits. !strict

comment:2 Changed 11 years ago by dante

(In [14969]) refs #7390 - extra tabs in Button.js

comment:3 Changed 10 years ago by Eugene Lazutkin

In [15808] this line of _base/html.js:

af(node, 1).Enabled = (opacity == 1 ? false : true);

is replaced with this one:

af(node, 1).Enabled = !(opacity == 1);

Why not like this:

af(node, 1).Enabled = opacity != 1;

saving 3 characters and making it easier to understand.

comment:4 Changed 10 years ago by dante

(In [16200]) refs #7390 - style cleanups

comment:5 Changed 10 years ago by dante

(In [17513]) refs #7390 - super-minor style patch testing jslint warning

comment:6 Changed 10 years ago by cb1kenobi

(In [17956]) Added whitespace to _isDocumentOk(), refs #7390.

comment:7 Changed 10 years ago by bill

(In [17961]) Comment formatting as per dojo style guidelines, refs #7390 !strict.

comment:8 Changed 10 years ago by bill

(In [17962]) Fix comment formatting as per dojo's style guidelines, and to make the doc parser work. Refs #7390 !strict.

comment:9 Changed 10 years ago by Douglas Hays

(In [20519]) Refs #7390. Minor whitespace style cleanups in dijit/form

comment:10 Changed 8 years ago by cjolif

The style guide link mentioned in the ticket (that is : http://dojotoolkit.org/developer/StyleGuide) is not working.

comment:11 Changed 8 years ago by dante

(In [23600]) refs #7390 - simple style making my eyes hurt

comment:12 Changed 8 years ago by bill

(In [25105]) missing semicolons plus a few spacing fixes, refs #7390 !strict

comment:13 Changed 8 years ago by bill

(In [25116]) spacing fixes, refs #7390 !strict

comment:14 Changed 8 years ago by bill

(In [25524]) spacing fixes, refs #7390 !strict

comment:15 Changed 6 years ago by bill

In [30892]:

fix indentation, refs #7390 !strict

comment:16 Changed 3 years ago by dylan

Milestone: future1.11
Resolution: fixed
Status: newclosed

This meta ticket has probably outlived its usefulness given that we haven't used it in 3 years.

Note: See TracTickets for help on using tickets.