Opened 14 years ago
Closed 7 years ago
#7390 closed task (fixed)
[meta] style guideline adherence
Reported by: | dante | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.11 |
Component: | General | Version: | 1.1.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
There are a lot of flubs in our own commitment to style guidelines. This meta ticket is to be used to commit small style guidelines changes. This is mostly for small nits, like spaces between if () and } else { etc.
the guidelines are defined at: http://dojotoolkit.org/developer/StyleGuide
Change History (16)
comment:1 Changed 14 years ago by
comment:3 Changed 14 years ago by
In [15808] this line of _base/html.js:
af(node, 1).Enabled = (opacity == 1 ? false : true);
is replaced with this one:
af(node, 1).Enabled = !(opacity == 1);
Why not like this:
af(node, 1).Enabled = opacity != 1;
saving 3 characters and making it easier to understand.
comment:5 Changed 13 years ago by
comment:7 Changed 13 years ago by
comment:8 Changed 13 years ago by
comment:9 Changed 13 years ago by
comment:10 Changed 11 years ago by
The style guide link mentioned in the ticket (that is : http://dojotoolkit.org/developer/StyleGuide) is not working.
comment:12 Changed 11 years ago by
comment:16 Changed 7 years ago by
Milestone: | future → 1.11 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
This meta ticket has probably outlived its usefulness given that we haven't used it in 3 years.
(In [14743]) refs #7390 - minor space and tab nits. !strict