Opened 14 years ago

Closed 12 years ago

Last modified 12 years ago

#739 closed defect (fixed)

Consider making package method detection aware of comments

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 1.0
Component: Loader Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

Dojo looks for certain methods in the source files related to package loading, both as part of the build process and as part of package loading (for xdomain and for debugAtAllCosts). However, it does a simple regexp that does not take into account that the matches may be inside commented out code.

Change History (7)

comment:1 Changed 13 years ago by dylan

Component: CorePackageSystem
Owner: changed from anonymous to alex

comment:2 Changed 13 years ago by James Burke

Owner: changed from alex to James Burke

Stealing io and package bugs from Alex. Holler if you want it back.

comment:3 Changed 13 years ago by James Burke

Milestone: 0.40.5

Pushing to 0.5. I am not comfortable doing it for 0.4.1, since it could touch a few files. And maybe we can pick it up as part of other improvements in the build process.

comment:4 Changed 12 years ago by James Burke

Milestone: 0.91.0

Wanted to get this for 0.9, but ran out of time. Behavior is the same as in 0.4, but still not very desirable.

comment:5 Changed 12 years ago by James Burke

Looks like this is fixed now with the new debugAtAllCosts support that uses the xdomain loader. loader_xd.js has code now to remove comments before looking for dependencies, and buildUtil.js has the removeComments() function that is used during build.

Last remaining place is in buildUtilXd.makeXdContents(). Need to have it reuse the function in buildUtil.js.

comment:6 Changed 12 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [10814]) Fixes #739, make package method detection aware of comments. Last holdout was in buildUtilXd.js.

comment:7 Changed 12 years ago by James Burke

(In [10815]) Refs #739. Have xd loader use same comment removal code as the build system, so behavior is consistent. Also makes xd loader smaller.

Note: See TracTickets for help on using tickets.