Opened 13 years ago

Closed 9 years ago

#7369 closed defect (wontfix)

QueryReadStore.php returns full result list on query for ""

Reported by: haysmark Owned by: wolfram
Priority: high Milestone: future
Component: DojoX Data Version: 1.1.1
Keywords: Cc: paulprince
Blocked By: Blocking:

Description (last modified by haysmark)


Clear the very bottom box that contains "a" so it is completely blank. Press store.fetch. A query for "" should return 0 results, but instead the PHP returns everything, which is wrong. I've never had this problem before with QueryReadStore?, so I suspect it is a problem with dojox/data/tests/stores/QueryReadStore.php.

The net effect is that you can't clear the FilteringSelect? on that page; it will always select Alabama since "" returns the full list and Alabama is #1 on the list. Basically, only a query for "*" should return everything, and a query for "" should only return things that match exactly "" *from start to end*. In this case, none of the data matches "" exactly so the PHP should return nothing.

wolfram I don't know PHP too well but it looks like your code based on the SVN log, could you take a look at it?

Change History (8)

comment:1 Changed 13 years ago by haysmark

Description: modified (diff)
Summary: QueryReadStore.php returns full result list on query for ''QueryReadStore.php returns full result list on query for ""

comment:2 Changed 13 years ago by paulprince

see mine and bill's comments on #5794 - if the server-side script should always return [] for query="" (which sounds reasonable to me), why even bother to make the ajax request? It would be nice to eliminate these requests.

comment:3 Changed 13 years ago by paulprince

Sorry, the related ticket is actually #5974.

The more I think about this, I've changed my mind. See my comments at #5974

comment:4 Changed 13 years ago by dante

Cc: paulprince added

comment:5 Changed 13 years ago by bill

Yah for back-compat reasons of FilteringSelect? I guess we need to fix this in QueryReadStore?, so that query.php?foo= just returns entries where foo is blank.

Wolfram, can you work on this?

comment:6 Changed 13 years ago by bill

Milestone: 1.21.3

move 1.2 bugs to 1.3

comment:7 Changed 13 years ago by dante

Milestone: 1.3future

can we act on this one way or another?

comment:8 Changed 9 years ago by Kitson Kelly

Resolution: wontfix
Status: newclosed

Abandoned ticket, against a test feature that isn't working properly with a deprecated component and API. If someone wants to fix this, they can reopen the ticket.

Note: See TracTickets for help on using tickets.