Opened 11 years ago

Closed 4 years ago

#7342 closed defect (patchwelcome)

dojox.widget.Toaster not direct child of body

Reported by: nonken Owned by: nonken
Priority: high Milestone: 1.13
Component: DojoX Widgets Version: 1.1.1
Keywords: Toaster, positioning Cc:
Blocked By: Blocking:

Description

Taster needs to be direct child of the body because of absolute positioning. Otherwise it will position wrongly when in relative positioned elements.

Change History (10)

comment:1 Changed 11 years ago by nonken

Resolution: fixed
Status: newclosed

(In [14657]) Changed toaster to be direct child of body, fixes #7342

comment:2 Changed 11 years ago by nonken

(In [14660]) wrong node by accident, refs #7342

comment:3 Changed 11 years ago by dylan

Milestone: tbd1.2

comment:4 Changed 11 years ago by rdunklau

Resolution: fixed
Status: closedreopened

I know i'm coming a bit too late, but why did you change it like this ? I mean, the toaster could have kept its original node when one is given as a constructor argument, but attached to the body when non is provided. Is there any problem with that ?

Thanks !

comment:5 Changed 11 years ago by bill

Milestone: 1.21.3

since these tickets were reopened, marking milestone as 1.3 (the next uncompleted milestone) so we don't overlook them

comment:6 Changed 11 years ago by nonken

Milestone: 1.31.4

comment:7 Changed 10 years ago by bill

Milestone: 1.41.5

comment:8 Changed 9 years ago by bill

Milestone: 1.51.6

1.5 is released, moving remaining tickets to 1.6

comment:9 Changed 8 years ago by bill

Milestone: 1.6future

(sadly) punting seemingly abandoned ticket and meta tickets to future

comment:10 Changed 4 years ago by dylan

Milestone: future1.12
Resolution: patchwelcome
Status: reopenedclosed

Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.