Opened 11 years ago
Closed 11 years ago
#7337 closed defect (fixed)
Build-mini breaks dijit ColorPalette
| Reported by: | dante | Owned by: | dante |
|---|---|---|---|
| Priority: | high | Milestone: | 1.2 |
| Component: | BuildTools | Version: | 1.1.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
The images used for dijit.ColorPalette are in the templates/ folder off of dijit/, which build_mini.sh removes (as all the templates get inlined). This breaks the widget after building (mini).
We should either move those fixed/required images into themes/a11y (?) or update the build script to avoid them. I'm fine with updating the script, but either needed this ticket to ref for commit or wanted to note this slight inconsistency in our file placement. (either in themes/ somewhere, or in a resources/ folder)
Change History (3)
comment:1 Changed 11 years ago by
| Description: | modified (diff) |
|---|---|
| Owner: | changed from bill to dante |
comment:2 Changed 11 years ago by
On second thought I guess that templates/a11y is fine since (even though we use those images all the time) the only reason we have those images is to support high-contrast mode. Otherwise would be using background-color for all the nodes.
comment:3 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [14764]) fixes #7337 - moving the a11y-required images for ColorPalette? out of templates/ and into themes/, where build-mini won't remove them. Also removing unused buttons/ folder and image, as no explanation or use can be found for its being there.
Could put them in themes/a11y although that's really for high-contrast mode images, not these images which are used all the time. I guess resources or really resources/images would match dojo/ (dojo core).