Opened 11 years ago

Closed 11 years ago

#7315 closed defect (fixed)

TabContainer: does not format properly when class specified

Reported by: SlickT10 Owned by:
Priority: high Milestone: 1.2
Component: Dijit Version:
Keywords: dijit TabContainer ContentPane layout Tabs Cc:
Blocked By: Blocking:

Description (last modified by bill)

When using only a TabContainer and ContentPanes the tabs stack. A live example is at http://ktiedt.dojotoolkit.org/slick.html (thanks to tk). This is actually code from the newly released book Mastering Dojo. Using 1.1.1 this page works as expected. But with the latest builds it breaks.

Change History (2)

comment:1 Changed 11 years ago by bill

Description: modified (diff)
Summary: TabContainer does not format properly when placed in a clean page.TabContainer: does not format properly when class specified

Hmm, yah, it's a problem with specifying a class to the TabContainer widget, because the specified class is overriding the default class and thus certain CSS rules aren't taking effect (in particular .dijitTabContainerTop-tabs { ... }).

I'll think about this issue some before responding further.

comment:2 Changed 11 years ago by bill

Resolution: fixed
Status: newclosed

(In [14624]) Change the layout widgets so that class is additive, not destructive. (IE, setting class="foo" adds "foo" to existing dijitBorderContainer class). Fixes #7160, #7315 !strict

Note: See TracTickets for help on using tickets.