[patch][ccla]BorderContainer: programmatic creation doesn't create splitter

[bill]

See test_BorderContainer_prog.html.

Pressing "add left pane" button creates a left pane with splitter:true parameter, but yet there's no splitter, and not even a draggable gutter (well, the div is there for a gutter but it's 5x0 so it's not visible.

[bill]

I looked over this patch briefly. Seems basically good except that apparently you are setting child._setup = true but never clearing that flag when the child is removed. I don't see a reason to have the

if(child._setup){ return; } 
child._setup = true; 

block of code at all.

(There's nothing special about BorderContainer; TabContainer etc. have the same issues with initial children vs. added children.)

[bill]

OK, just talked to Adam. Looks like there's a generic problem w/layout widgets where setupChild() is called twice for any child added before startup, ex:

var bc = new BorderContainer();
bc.addChild(myChild);
bc.startup();

Problem code is in _LayoutWidget.js:

addChild: function(/*Widget*/ child, /*Integer?*/ insertIndex){
	this.inherited(arguments);
	this._setupChild(child);
},

I guess that shouldn't call _setupChild() if startup() hasn't been called yet. (Would need to test it though)

[Adam Peller]

(In [14862]) Move splitter setup to _setupChild so that it is processed for late additions after startup. Refs #7310 !strict

[Adam Peller]

(In [14866]) Don't call _setupChild twice. Only call from addChild for late additions (after startup) Fixes #7310 !strict