Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#7309 closed defect (fixed)

ClientFilter's sort not working (always)

Reported by: Sam Foster Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.2
Component: DojoX Data Version: 1.1.1
Keywords: Cc: Kris Zyp
Blocked By: Blocking:

Description

The comparator that dojox.data.ClientFilter?'s makeComparator creates returns true/false instead of -1/+1 as required by Array.sort (​http://developer.mozilla.org/en/docs/Core_JavaScript_1.5_Reference:Global_Objects:Array:sort#Parameters)

.. that appears to be causing an issue with sorting a resultset- at least when I have it return -1/1 my sort suddenly works - see patch

Attachments (2)

7309_clientFilterSort.patch​ (1.8 KB) - added by Sam Foster 12 years ago.
[PATCH] [CLA] ClientFilter?.js - makeComparator functions return -1/1, new sorting unit test
dojox.data.ClientFilter_20080730.patch​ (28.7 KB) - added by Jared Jurkiewicz 12 years ago.
Fixed EOL styles, added EOL property

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by Sam Foster

Attachment: 7309_clientFilterSort.patch​ added

[PATCH] [CLA] ClientFilter?.js - makeComparator functions return -1/1, new sorting unit test

comment:1 Changed 12 years ago by Kris Zyp

Resolution: → fixed
Status: new → closed

(In [14622]) fixes #7309

Changed 12 years ago by Jared Jurkiewicz

Attachment: dojox.data.ClientFilter_20080730.patch​ added

Fixed EOL styles, added EOL property

comment:2 Changed 12 years ago by Jared Jurkiewicz

(In [14623]) Fixing properties, etc. refs #7309

comment:3 Changed 12 years ago by dylan

Milestone: tbd → 1.2
Note: See TracTickets for help on using tickets.