Opened 11 years ago

Closed 8 years ago

Last modified 8 years ago

#7292 closed enhancement (fixed)

[Build] Primary Build File Excludes Copyright

Reported by: ole Owned by: James Burke
Priority: high Milestone: 1.7
Component: BuildSystem Version: 1.1.0
Keywords: Cc: ole.ersoy@…, Rawld Gill
Blocked By: Blocking:

Description

When I opened explosive.js.uncompressed.js I noticed that it first has the dojo copyright, then the dojo dependencies, then the explosive dependencies. Seems reasonable to put the the explosive module copyright right before the explosive module dependencies. That way it's clear what's covered by the dojo copyright and what's covered by the 'explosive' module copyright.

Thoughts?

  • Ole

Change History (5)

comment:1 Changed 11 years ago by ole

OK - Robert Coup pointed out that a copyrightFile property can be set on the layer definition that defines the copyright used by the the layer.

There's also a great example of this in the layers.profile.js example that comes with dojo, however it is missing in the documentation:

http://dojotoolkit.org/book/dojo-book-0-9/part-4-meta-dojo/package-system-and-custom-builds

One thing that might be good to point out in the documentation is that when using a copyrightFile property in the layer definition, all of the code in the layer becomes covered by that copyright. Therefore the dojo copyright should be blended with the 'explosive copyright' or separate mutually exclusive layers should be produced for the dojo 'explosive' dependency and the 'explosive' dependency.

I'll add some notes in the comment section of the documentation of the dojo book. I'll leave the ticket as open in case anyone wants to formalize the documentation more in the future.

comment:2 Changed 11 years ago by dylan

Milestone: tbdfuture

comment:3 Changed 11 years ago by James Burke

Component: GeneralBuildSystem
Owner: changed from anonymous to James Burke

comment:4 Changed 8 years ago by ben hockey

Resolution: fixed
Status: newclosed

it seems nobody has had a need for this ticket to be open in the last 4 years - closing it now.

comment:5 Changed 8 years ago by bill

Cc: Rawld Gill added
Milestone: future1.7

Not sure if the documentation ever got updated. The link above has unfortunately disappeared into a 404. I do see doc for copyrightFile in http://dojotoolkit.org/reference-guide/build/profiles.html:

Optional. Filename of a simple text file that will be prepended to build layer files. If omitted, the default Dojo copyright notice will be used instead.

You could add a comment on that page if it needs to be updated [more].

In any case marking milestone as 1.7 just because we need to set it to something other than future/tbd (for closed tickets).

Last edited 8 years ago by bill (previous) (diff)
Note: See TracTickets for help on using tickets.