Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7283 closed enhancement (wontfix)

Upgrade Firebug Lite to 1.2

Reported by: Chris Mitchell Owned by: Mike Wilcox
Priority: high Milestone: future
Component: Core Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

Firebug Lite 1.2 is now available. http://getfirebug.com/lite.html

It would be nice to upgrade the embedded version in dojo to this level (1.2?)

Change History (14)

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from anonymous to Mike Wilcox

We've forked significantly. I'm not sure anyone was aware that the code was being maintained elsewhere. Mike, can you take a peek and size up a merge? Perhaps we should talk to the firebug people about taking our code? We were being good about keeping Dojo code out of firebug, at least initially.

comment:2 Changed 11 years ago by Mike Wilcox

They've forked too. This wasn't built by the Firebug guys, this was built by Azer Kodfabrik, and when they saw it, they asked him if they could use it. So it's an entirely different code base.

It uses his PI library. Although the library seems to have been built primarilly as the foundation for FB Lite, it also includes some comet stuff which would seem to be superfluous.

But more importantly, the PI library does a no-no and extends native JS objects - prototyping Functions and Arrays, etc.

Due to that, I would say that unfortunately we can't use it without major reconstruction of the code, whether it be rewriting the library or converting it to dojo. It may be easier to just upgrade our version.

The one thing ours has that theirs doesn't is a popup window.

Link to PI: http://getfirebug.com/releases/lite/1.2/pi.js

Link to firebug-lite: http://getfirebug.com/releases/lite/1.2/firebug-lite.js

comment:3 in reply to:  2 Changed 11 years ago by Mike Wilcox

Okay good news. A new version has been released that doesn't prototype native objects.

It's still missing some key functionality (debug, info, warn, error). But that should be implemented shortly (perhaps by me). And I've already done a test that successfully imports the new version without modification (except for the dojo.provide, which I found necessary)

So this should be implemented soon. It won't have the popup window though :( (thats a major change)

comment:4 Changed 11 years ago by James Burke

Sounds like there are more authors with this new firebug lite? Do we need CLA coverage from them all to include it in our repo?

comment:5 Changed 11 years ago by bill

We've got a LICENSE file in the firebug directory. (According to my very limited legal knowledge) that's sufficient, but feel free to correct me.

comment:6 Changed 11 years ago by Chris Mitchell

Signed CLA's help make the legal reviews of this much easier if they're able to (and makes absorbing the external code safer from dojo's perspective). Without the cla, there's no telling where the new code came from... licenses don't address pedigree.

comment:7 Changed 11 years ago by Mike Wilcox

An email request has been sent.

comment:8 Changed 11 years ago by Mike Wilcox

BTW, the new dojo-lite uses a js library called PI. the unfinished docs are here: http://pi.kodfabrik.com/documents/base/base/

CLA stuff aside, let me know if it's an issue to have a library within a library. It's more like JQuery than Dojo, so a port wouldn't be easy.

comment:9 Changed 11 years ago by Adam Peller

Icky. The library dependency in such a low-level tool was a design point we were trying to avoid with the old firebug, even in our own version. Looks like they play with core object prototypes, too. Was a library really necessary? Are they leveraging it that much and can they reconsider?

comment:10 Changed 11 years ago by dylan

Milestone: tbdfuture

This is clearly not a simple upgrade, so deferring to the future.

comment:11 Changed 11 years ago by Mike Wilcox

peller, do we have direction for this?

Our version of Firebug is pretty buggy. There are constant problems.

The 1. version is a lot less buggy, but I don't know if it's been tested with large apps. It also doesn't open in a popup window.

comment:12 Changed 11 years ago by James Burke

I think the PI dependency is the blocker as well as making sure all the contributors to this new version sign a CLA. But the PI dependency sounds undesirable at best. What are the problems with our current Firebug?

In the long run this seems less necessary now that Safari and IE 8 have a real console and debugger tools. For IE 7 testing, try IE 8 in compatibility mode. Not sure it makes much sense keep improving this for just the IE 6 case?

comment:13 Changed 11 years ago by Mike Wilcox

Resolution: wontfix
Status: newclosed

peller said to put the kaibosh to this. Any requests or questions about using the official Firebug Lite should be directed to him. I will continue to maintain Dojo's version.

comment:14 Changed 11 years ago by Adam Peller

The record should show that we wanted to and still want to merge our code in to the mainstream and/or use the official version. So far, we haven't been able to work that out.

Note: See TracTickets for help on using tickets.