After sort, scroller reset to (0,0)

[Joseph Scheuhammer]

Invoking sort on the grid by, say, clicking a column header causes parts of the DOM to be replaced. A side effect is that the current position of the scroller is lost, and it is reset to (0,0).

To reproduce:

1. load ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_keyboard.html
2. move the grid's horizontal scroll bar such that column 15 is in view.
3. click column 15 header to sort the grid.
4. after the sort is finished, the horizontal position of the grid is reset back to column 1.

The grid scroll position should not change.

[Nathan Toone]

just a clarification - horizontal scroll should not be reset...what about vertical scroll? Since you are sorting, there is no concept of "where you were" - that is,

[Nathan Toone]

(In [14868]) Fixes #7273 Fixes #7186 - restore scroll position when sorting or resizing columns !strict

[Jared Jurkiewicz]

This problem still occurs on 1.3

[Jared Jurkiewicz]

I looked at the changeset. It only restores vertical position, not both vertical and horizontal...

[Jared Jurkiewicz]

Also, there is another problem specific to IE. When it snaps back to the left, the header doesn't follow and alignment is off. I'll attach two files that readily show this. I tracked down (Along with Ben Schell) how to at least fix the alignment issue on IE. I'll attach a patch as well.

In reality, it ought to be keeping horizontal position, but at min it needs to at least keep the headers aligned if it snaps back.

[Jared Jurkiewicz]

HTML file showing header offset problem on IE

[Jared Jurkiewicz]

data file for grid.html

[Jared Jurkiewicz]

In IE, load grid.html, then scroll all the way right (Do not change top/bottom scroll). Click sort. The table body snaps back to all the way left ... but the header does not. It won't correct until you move a scroller.

I should also note that if you have already scrolled down and then right, it doesn't occur. It only occirs when scrollTop = 0;

We tracked this down to on IE the scroll event doesn't seem to fire for scrollTop = 0. We found a simple workaround for it. I'll attach a patch next.

[Jared Jurkiewicz]

Patch to fix the IE header align issue. (Doesn't fix the snap left, but it does fix IE so they stay aligned like FF does)

[Bryan Forbes]

(In [16562]) * Applying patch from Jared (fixes #7273 !strict).

[Bryan Forbes]

I checked in the patch to fix the header align issue in IE. I'm moving this to future because this is going to be an invasive fix.

[evan]

Had a thorough testing on all browsers by using the ​mentioned test case, not seeing this issue anymore in 1.6, so closing this as worksforme.

[Bryan Forbes]

I just tested this again in Firefox 3.6, IE6, IE7, IE8, Chrome 10.0.648.127, Chrome 9.0.597.107, and Safari 5.0.3 (6533.19.4). Safari and Chrome 9 are the only ones that returns to the top. This needs further investigation as to why Safari and Chrome 9 don't return to the previous scroll position.

[bill]

Moving apparently forgotten ticket to 1.8.

[Colin Snover]

Bulk update of open ticket priorities.

[Bryan Forbes]

According to #12224, this behavior happens because of the first line of dojox.grid._View#render. I need to investigate this further.

[Bryan Forbes]

#12224 is a duplicate of this ticket.

[cjolif]

this ticket is a 1.8 blocker because it was moved automatically from high to blocker at some point. See:

"Bulk update of open ticket priorities."

that's why I think we can downgrade it to not block the release.

[Colin Snover]

1.8 has been tagged; moving all outstanding tickets to next major release milestone.

[bill]

DojoX Grid and EnhancedGrid are deprecated in favor of ​dgrid and ​gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.