Opened 13 years ago
Closed 10 years ago
#7252 closed enhancement (wontfix)
5 New Themes for Dijit
Reported by: | fobulous | Owned by: | nonken |
---|---|---|---|
Priority: | low | Milestone: | future |
Component: | themes | Version: | 1.1.1 |
Keywords: | Cc: | nonken, David Schwartz | |
Blocked By: | Blocking: |
Description
To start, I have signed the CLA :)
-- I have taken the liberty of creating 5 new themes for the toolkit and have received much input from those on #dojo, making changes to each theme accordingly. The CSS codebase of the themes is an enhanced soria theme with particular concentration in edge quality enhancement of tabs with rounded corners (using pngs), which degrade nicely under IE6 by making obvious use of gif counterparts. Improvements were also made in the editor icons and tree icons, each featuring subtle to obvious differences to match the corresponding theme. Themes have been tested under IE6/7, FF2/3, Safari 3 and Opera.
Attachments (1)
Change History (10)
Changed 13 years ago by
Attachment: | newthemes.tar.bz2 added |
---|
comment:1 Changed 13 years ago by
Owner: | changed from [email protected]… to dante |
---|
comment:2 follow-up: 3 Changed 13 years ago by
Hi fobulous, that's great you have new themes.
I'm not quite sure where we should put them. The obvious place is in the dijit/ tree although the current three themes are as much as I can handle testing/updating (and themes do often need updating due to template changes etc). I'm sure we've talked endlessly about having a theme-garden etc. but we haven't actually implemented anything like that.
Another question: if these themes are based on soria, should they really be new themes, or is it better (maintenance-wise) to first include soria and then include your changes on top, to override?
Anyway, I'm on #dojo a lot of the time, surprised I haven't talked to you. (I'm wild.bill)
comment:3 Changed 13 years ago by
Hi Bill,
Maintenance-wise, I actually considered something similar myself. To make things easier for me during the creation process, I created a "templated" theme from which I built the 5 new themes using a shell script. So effectively, these 5 themes are like one extra theme for the toolkit. The 6th theme that I did not include is their template named nudo. The most time consuming part of the process were the theme images; but that challenge was met by creating a shell script and imagemagick for much of the image processing.
You may have a point that these are not new themes, just several skins of soria. I will definitely find you on #dojo to discuss this issue further. My handle is gtducati.
comment:4 Changed 13 years ago by
Milestone: | tbd → future |
---|---|
Owner: | changed from dante to nonken |
Priority: | normal → low |
did we decide on dojox/ for this, or perhaps a themes/ top-level repo to host community (cla) contributed themes of varying completeness?
comment:5 Changed 13 years ago by
Milestone: | future → 1.4 |
---|---|
Status: | new → assigned |
This will go along with the themegarden which is in development
comment:6 Changed 12 years ago by
Cc: | drs added |
---|
comment:7 Changed 12 years ago by
Milestone: | 1.4 → future |
---|
comment:8 Changed 12 years ago by
Cc: | David Schwartz added; drs removed |
---|
comment:9 Changed 10 years ago by
Resolution: | → wontfix |
---|---|
Status: | assigned → closed |
I'm not interested in checking more themes into dijit, because the themes we have now have been abandoned by their owners and I can't maintain them all. Plus which, any new themes should really be variants on claro, generated from a separate variables.less file. So, closing this for now.
5 new themes for dijit