Opened 11 years ago

Closed 4 years ago

#7245 closed enhancement (patchwelcome)

MultiSelect: populate options from data store

Reported by: Goran Miskovic Owned by:
Priority: high Milestone: 1.13
Component: Dijit - Form Version: 1.1.1
Keywords: multiselect, data store Cc: dante
Blocked By: Blocking:

Description

As per discussion in http://dojotoolkit.org/forum/dijit-dijit-0-9/dijit-support/populating-markup-multiselect it would be grate to have option to populate options from data store and not only from markup.

I am not using svn so I can't create difference. Added lines in attached file are prefixed with ++.

Attachments (5)

MultiSelect.tar.gz (2.3 KB) - added by Goran Miskovic 11 years ago.
multiselect.php (1.4 KB) - added by Goran Miskovic 11 years ago.
example
multiselect.txt (384 bytes) - added by Goran Miskovic 11 years ago.
MultiSelectDifference.js (3.0 KB) - added by Goran Miskovic 11 years ago.
MultiSelect.js (3.0 KB) - added by Goran Miskovic 11 years ago.

Download all attachments as: .zip

Change History (26)

comment:1 Changed 11 years ago by Nathan Toone

Milestone: tbd1.3
Owner: set to Nathan Toone

comment:2 Changed 11 years ago by Goran Miskovic

It looks as if I've uploaded original file. :(

Anyways in attached archive there is difference file (created manually), changed file and example.

Changed 11 years ago by Goran Miskovic

Attachment: MultiSelect.tar.gz added

comment:3 Changed 11 years ago by Goran Miskovic

It looks as if it is not possible to upload archive files. Or to be precise uploaded archive is not kept in original format. Sorry about mess. :)

Changed 11 years ago by Goran Miskovic

Attachment: multiselect.php added

example

Changed 11 years ago by Goran Miskovic

Attachment: multiselect.txt added

Changed 11 years ago by Goran Miskovic

Attachment: MultiSelectDifference.js added

Changed 11 years ago by Goran Miskovic

Attachment: MultiSelect.js added

comment:4 Changed 11 years ago by bill

Milestone: 1.31.4

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

comment:5 Changed 11 years ago by Nathan Toone

Milestone: 1.4future

comment:6 Changed 9 years ago by Nathan Toone

Owner: Nathan Toone deleted

Unassigning my tickets.

comment:7 Changed 9 years ago by Douglas Hays

Owner: set to Douglas Hays

comment:8 Changed 9 years ago by Goran Miskovic

I got MultiSelect? populated from data store working with dojo 1.5 and if needed I can upload the patch.

comment:9 Changed 8 years ago by bill

Component: DijitDijit - Form

comment:10 Changed 7 years ago by dylan

Milestone: future1.9
Owner: changed from Douglas Hays to Goran Miskovic
Status: newpending

We obviously did not get a chance to look at this in a reasonable amount of time.

If you would like to resubmit a patch against Dojo 1.9 trunk using object stores, I will review and get it into trunk.

Please make sure you have a CLA on file, http://staging.dojofoundation.org/about/claForm

comment:11 Changed 7 years ago by bill

Owner: changed from Goran Miskovic to Douglas Hays
Status: pendingassigned

Oh, I think this was already implemented via [17740] and then transferred to dijit in [19071]. Just needs a test case (actually, there's already a test case in dojox/form/tests/test_CheckedMultiSelect.html, so that should just be moved to dijit.

(If the support was there from those commits, test case should be added and then this should be closed as fixed in 1.4.)

Last edited 7 years ago by bill (previous) (diff)

comment:12 Changed 7 years ago by Goran Miskovic

I would say that you are correct: Setting options from given store is indeed implemented in changesets [17740] and [19071].

Thank you.

comment:13 Changed 7 years ago by dylan

Resolution: fixed
Status: assignedclosed

comment:14 Changed 7 years ago by bill

Resolution: fixed
Status: closedreopened

As I wrote above: If the support was there from those commits, test case should be added and then this should be closed as fixed in 1.4.

Actually, looks like most (or all?) of the tests in dojox/form/tests/test_CheckedMultiSelect.html should be moved to dijit/tests/form/test_MultiSelect.html.

Last edited 7 years ago by bill (previous) (diff)

comment:15 Changed 7 years ago by Douglas Hays

Milestone: 1.91.4
Status: reopenedassigned

comment:16 Changed 7 years ago by Douglas Hays

dijit/form/MultiSelect does not inherit from _FormSelectWidget and so doesn't currently support stores

comment:17 Changed 7 years ago by Douglas Hays

Milestone: 1.42.0

Most of CheckedMultiSelect? needs to be merged with MultiSelect? and have it become the new base class.

comment:18 Changed 7 years ago by bill

Milestone: 2.01.10

Might as well check this into SVN and then merge to github, so it's available for the 1.x and 2.x streams.

comment:19 Changed 6 years ago by Douglas Hays

Owner: Douglas Hays deleted
Status: assignedopen

comment:20 Changed 6 years ago by cjolif

Milestone: 1.102.0

Nobody is assigned to this. waiting for someone to be assigned moving this out of 1.10.

comment:21 Changed 4 years ago by dylan

Milestone: 2.01.12
Resolution: patchwelcome
Status: openclosed

Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.