[patch][cla]DnD highlighting is not sensitive to the direction of the container (horizontal vs. vertical)

[MaxMotovilov]

The DnD highlighting of the target anchor is always above or below, even in horizontal containers. A simple addition to Common.css in each theme appears to fix it. Patches for tundra and soria are attached.

[Adam Peller]

is there a CLA?

[bill]

Nikolai might as well check this in (after we get a CLA), after he finishes #6240.

[nonken]

DnD needs to get a general overhaul including tree dnd and general dnd styling improvements

[Eugene Lazutkin]

The patches are trivial, I think they can be safely accepted without CLA. (I contacted Max and ask him to submit CLA anyway).

[Eugene Lazutkin]

I got email from Aimee confirming that Max has CLA on file with us.

[bill]

1.5 is released, moving remaining tickets to 1.6

[Adam Peller]

moved to 1.7.1 for consideration. Please move to 1.8 as appropriate.

[Adam Peller]

actually moving to 1.7.1

[bill]

In [27710]:

DnD fixes regarding horizontal containers and the drop-insert line:

1. For horizontal containers, make the drop insert line be to the left/right of elements, rather than above/below them.

2. Fix jitter issues when moving over drop targets by trading off padding for border, rather than just by creating a border.

3. Change the claro drop insert line for generic DnD containers be 2px rather than 1px, to match the drop insert line for Tree.

4. On RTL pages for horizontal containers, dropping an element A near the right edge of an element B should put A (before B (in the page flow), not after it.

I put the CSS rules into dijit.css, even though they aren't part of dijit. I think they'd make more sense in dojo/resource/dnd.css, but for some reason the precedent in dojo/ is to have the drop insert line rules in dojo/tests/dndDefaults.css, which doesn't get included into non-test pages.

Fixes #7225 !strict.

[liucougar]

In [27816]:

refs #7225: make sure DnD enabled grid header is properly layed out

[liucougar]

In [27829]:

refs #7225: claro is different from the other themes

add padding to the other themes

[bill]

In [27945]:

On second thought, a margin between horizontal items isn't needed: unlike Tree, there's no point to distinguishing between "drop after item 2" and "drop before item 3". Ideally those two states should look the same, although I don't know how to achieve that. Refs #7225.