Opened 11 years ago

Closed 7 years ago

Last modified 7 years ago

#7225 closed defect (fixed)

[patch][cla]DnD highlighting is not sensitive to the direction of the container (horizontal vs. vertical)

Reported by: MaxMotovilov Owned by: bill
Priority: high Milestone: 1.8
Component: themes Version: 1.1.1
Keywords: DnD Cc: Eugene Lazutkin
Blocked By: Blocking:

Description

The DnD highlighting of the target anchor is always above or below, even in horizontal containers. A simple addition to Common.css in each theme appears to fix it. Patches for tundra and soria are attached.

Attachments (2)

tundra.Common.css.diff (473 bytes) - added by MaxMotovilov 11 years ago.
soria.Common.css.diff (467 bytes) - added by MaxMotovilov 11 years ago.

Download all attachments as: .zip

Change History (20)

Changed 11 years ago by MaxMotovilov

Attachment: tundra.Common.css.diff added

Changed 11 years ago by MaxMotovilov

Attachment: soria.Common.css.diff added

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from dante@… to dante

comment:2 Changed 11 years ago by Adam Peller

Summary: DnD highlighting is not sensitive to the direction of the container (horizontal vs. vertical)[patch]DnD highlighting is not sensitive to the direction of the container (horizontal vs. vertical)

is there a CLA?

comment:3 Changed 11 years ago by bill

Owner: changed from dante to nonken

Nikolai might as well check this in (after we get a CLA), after he finishes #6240.

comment:4 Changed 11 years ago by nonken

Milestone: 1.21.3
Status: newassigned

DnD needs to get a general overhaul including tree dnd and general dnd styling improvements

comment:5 Changed 10 years ago by nonken

Milestone: 1.31.4

comment:6 Changed 10 years ago by Eugene Lazutkin

The patches are trivial, I think they can be safely accepted without CLA. (I contacted Max and ask him to submit CLA anyway).

comment:7 Changed 10 years ago by Eugene Lazutkin

Cc: Eugene Lazutkin added

comment:8 Changed 10 years ago by Eugene Lazutkin

Summary: [patch]DnD highlighting is not sensitive to the direction of the container (horizontal vs. vertical)[patch][cla]DnD highlighting is not sensitive to the direction of the container (horizontal vs. vertical)

I got email from Aimee confirming that Max has CLA on file with us.

comment:9 Changed 10 years ago by bill

Milestone: 1.41.5

comment:10 Changed 9 years ago by bill

Milestone: 1.51.6

1.5 is released, moving remaining tickets to 1.6

comment:11 Changed 8 years ago by bill

Milestone: 1.61.7
Owner: changed from nonken to bill
Status: assignednew

comment:12 Changed 8 years ago by Adam Peller

moved to 1.7.1 for consideration. Please move to 1.8 as appropriate.

comment:13 Changed 8 years ago by Adam Peller

Milestone: 1.71.7.1

actually moving to 1.7.1

comment:14 Changed 8 years ago by bill

Milestone: 1.7.11.8

comment:15 Changed 7 years ago by bill

Resolution: fixed
Status: newclosed

In [27710]:

DnD fixes regarding horizontal containers and the drop-insert line:

  1. For horizontal containers, make the drop insert line be to the left/right of elements, rather than above/below them.
  1. Fix jitter issues when moving over drop targets by trading off padding for border, rather than just by creating a border.
  1. Change the claro drop insert line for generic DnD containers be 2px rather than 1px, to match the drop insert line for Tree.
  1. On RTL pages for horizontal containers, dropping an element A near the right edge of an element B should put A (before B (in the page flow), not after it.

I put the CSS rules into dijit.css, even though they aren't part of dijit. I think they'd make more sense in dojo/resource/dnd.css, but for some reason the precedent in dojo/ is to have the drop insert line rules in dojo/tests/dndDefaults.css, which doesn't get included into non-test pages.

Fixes #7225 !strict.

comment:16 Changed 7 years ago by liucougar

In [27816]:

refs #7225: make sure DnD enabled grid header is properly layed out

comment:17 Changed 7 years ago by liucougar

In [27829]:

refs #7225: claro is different from the other themes

add padding to the other themes

comment:18 Changed 7 years ago by bill

In [27945]:

On second thought, a margin between horizontal items isn't needed: unlike Tree, there's no point to distinguishing between "drop after item 2" and "drop before item 3". Ideally those two states should look the same, although I don't know how to achieve that. Refs #7225.

Note: See TracTickets for help on using tickets.