Opened 11 years ago

Closed 11 years ago

#7218 closed defect (fixed)

GridContainer doesn't update grip handles when PlottedDnd shows a DropIndicator

Reported by: jbalogh Owned by: dante
Priority: high Milestone: 1.2
Component: Dojox Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

Using the 2nd GridContainer? on http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/layout/tests/test_GridContainer.html:

  1. Observe that the middle column is full; it will have to expand vertically if we try to drop another element on it.
  2. Drag an object from the first or third columns, and hover it over the middle column so you see the outlined box showing where the dropped item will go.
  3. Notice that the grips are floating in space, since the container has dynamically resized but the grips didn't extend.

See the attached screenshot for an example.

Attachments (2)

floating_grips.png (121.3 KB) - added by jbalogh 11 years ago.
Screenshot of GridContainer? grips floating in space.
0001-Connect-_placeGrips-to-insertion-and-deletion-of-dro.patch (773 bytes) - added by jbalogh 11 years ago.
patch to fix grip placement

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by jbalogh

Attachment: floating_grips.png added

Screenshot of GridContainer? grips floating in space.

Changed 11 years ago by jbalogh

patch to fix grip placement

comment:1 Changed 11 years ago by jbalogh

The attached patch connects the _placeGrips function to the dropIndicator events. It's not perfect though, because you can create a noticeable flicker if the DashedZone gets inserted and deleted rapidly (which happens sometimes when the dragged element is in between other elements). But the patch is an improvement over having the grips floating in space.

The flicker problem could possibly be solved by making the DashedZone less sensitive, but I haven't looked into that yet.

And yes, the patch looks funny, but patch -p0 does the right thing; I tested it.

comment:2 Changed 11 years ago by dante

Owner: changed from Adam Peller to dante
Status: newassigned

comment:3 Changed 11 years ago by dante

Milestone: tbd1.2

comment:4 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [14599]) fixes #7218 - make grips extend to container size should the container resize during drag/positioning. !strict

Note: See TracTickets for help on using tickets.