Opened 13 years ago
Closed 13 years ago
#7218 closed defect (fixed)
GridContainer doesn't update grip handles when PlottedDnd shows a DropIndicator
Reported by: | jbalogh | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Dojox | Version: | 1.1.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Using the 2nd GridContainer?
on http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/layout/tests/test_GridContainer.html:
- Observe that the middle column is full; it will have to expand vertically if we try to drop another element on it.
- Drag an object from the first or third columns, and hover it over the middle column so you see the outlined box showing where the dropped item will go.
- Notice that the grips are floating in space, since the container has dynamically resized but the grips didn't extend.
See the attached screenshot for an example.
Attachments (2)
Change History (6)
Changed 13 years ago by
Attachment: | floating_grips.png added |
---|
Changed 13 years ago by
Attachment: | 0001-Connect-_placeGrips-to-insertion-and-deletion-of-dro.patch added |
---|
patch to fix grip placement
comment:1 Changed 13 years ago by
The attached patch connects the _placeGrips
function to the dropIndicator
events. It's not perfect though, because you can create a noticeable flicker if the DashedZone gets inserted and deleted rapidly (which happens sometimes when the dragged element is in between other elements). But the patch is an improvement over having the grips floating in space.
The flicker problem could possibly be solved by making the DashedZone less sensitive, but I haven't looked into that yet.
And yes, the patch looks funny, but patch -p0
does the right thing; I tested it.
comment:2 Changed 13 years ago by
Owner: | changed from Adam Peller to dante |
---|---|
Status: | new → assigned |
comment:3 Changed 13 years ago by
Milestone: | tbd → 1.2 |
---|
comment:4 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Screenshot of GridContainer? grips floating in space.