Opened 14 years ago

Closed 14 years ago

#7215 closed defect (fixed)

[patch] _browserRunner breaks Safari

Reported by: haysmark Owned by: Adam Peller
Priority: high Milestone: 1.2
Component: TestFramework Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:


Offending code:

	doh.debug = function(){, arguments);
		console.debug.apply(console, arguments);

_browserRunner checks for, but calls console.debug. Safari has but not console.debug. The result is that DOH throws an Undefined Value exception in Safari when you run a test without Dojo present.

Just substituting in looks goofy in Dojo tests with all of those blue i's to the left. I think we should check for console.debug separately and then fall back on a check.

Attachments (1)

dohfixsafari.patch (668 bytes) - added by haysmark 14 years ago.
Fixes _browserRunner in Safari.

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by haysmark

Attachment: dohfixsafari.patch added

Fixes _browserRunner in Safari.

comment:1 Changed 14 years ago by Adam Peller

Owner: changed from alex to Adam Peller
Status: newassigned

comment:2 Changed 14 years ago by Adam Peller

Resolution: fixed
Status: assignedclosed

(In [14943]) Use more precise testing for console methods to please Safari. Fixes #7215 !strict Thanks, haysmark.

Note: See TracTickets for help on using tickets.