Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#7213 closed defect (fixed)

[patch] _browserRunner tag not added in IE

Reported by: haysmark Owned by: Adam Peller
Priority: high Milestone: 1.2
Component: TestFramework Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

I'm talking about this line in runner.js: 

if(s && (s.substr(-9) == "runner.js")){

W3Schools says: "To extract characters from the end of the string, use a negative start number (This does not work in IE)."

Sure enough, the browserRunner tag isn't being added to the document. Since -9 is just shorthand for s.length-9, I changed it to that and now browserRunner loads in all browsers.

Attachments (1)

dohfixie.patch​ (549 bytes) - added by haysmark 12 years ago.
Fixes runner in IE to load browserRunner.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by haysmark

Attachment: dohfixie.patch​ added

Fixes runner in IE to load browserRunner.

comment:1 Changed 12 years ago by Adam Peller

Owner: changed from alex to Adam Peller
Status: new → assigned

comment:2 Changed 11 years ago by Adam Peller

Resolution: → fixed
Status: assigned → closed

(In [14941]) style fixes, plus use more portable inputs for String.substr. Fixes #7213 (thanks, haysmark) !strict

comment:3 Changed 11 years ago by Adam Peller

(In [14942]) a couple more style fixes Refs #7213 !strict

comment:4 Changed 11 years ago by Adam Peller

(In [14950]) undo dojo.forEach in non-dojo block. Refs #7213 !strict

Note: See TracTickets for help on using tickets.