Opened 11 years ago
Closed 11 years ago
#7206 closed defect (fixed)
[patch] [cla] TabContainer: closable tab pane leaks dom nodes when closed.
| Reported by: | afryer | Owned by: | bill |
|---|---|---|---|
| Priority: | high | Milestone: | 1.2 |
| Component: | Dijit | Version: | 1.1.1 |
| Keywords: | dom node leak TabContainer StackContainer addChild closable | Cc: | |
| Blocked By: | Blocking: |
Description
When a closable tab pane is created, it instantiates a menu and a menu item. When the tab pane is closed, the menu is destroyed using the destroy() method. The menuItem is not destroyed and is leaked.
I also see dojo.connect calls made on the button and menu widgets that don't have corresponding dojo.disconnect calls when the tab pane is closed.
Have attached a test case and a patch file to fix the leak.
Attachments (2)
Change History (6)
Changed 11 years ago by
| Attachment: | test_TabContainer_Programmatic_leak.html added |
|---|
Changed 11 years ago by
| Attachment: | StackContainer_patch.txt added |
|---|
patch for StackContainer?.js that fixes closable child leak
comment:1 Changed 11 years ago by
| Milestone: | tbd → 1.2 |
|---|---|
| Owner: | set to bill |
| Summary: | closable tab pane leaks dom nodes when closed. → [patch] [cla] TabContainer: closable tab pane leaks dom nodes when closed. |
Cool, leak fixes always appreciated! BTW if your attachments have a .patch or .diff extension they show up formatted nicely, see for example http://bugs.dojotoolkit.org/attachment/ticket/5417/5417.patch
comment:2 Changed 11 years ago by
Which version is your patch against? I tried it against the 1.1.1 StackContainer?.js [13089] and the latest [14420] but it match up.
comment:3 Changed 11 years ago by
| Status: | new → assigned |
|---|
comment:4 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
test demonstrating closable tab pane leak when run in sIEve