CDATA sections in XML data source are not correctly rendered in a grid

[niciliketo]

When trying to render XML to a grid, blanks are displayed when the XML is in a CDATA section. The CDATA sections is required because the content includes HTML tags. The problem appears to be in the Dojox.data.XmlStore? component, specifically the XmlItem? piece.

Attached are,

1. an example of the XML I want to render to the grid.
2. the code I am using
3. A suggested modified version of the XmlData?.js file which does handle CDATA.

I have tested the issue and the fix against Firefox 3.0 and IE

[niciliketo]

A version of the XmlStore?.js which I have changed to make CDATA work

[niciliketo]

An example of data including CDATa

[Jared Jurkiewicz]

Are you covered under CLA? If so, I can apply your changes fine.

[niciliketo]

Hi Jared,

No, I am not. I can apply if this would be easier.

I am just an end user of Dojo, and don't pretend to understand everything that this change would affect. That is why it was just submitted as a suggestion.

Thanks,

Nic.

[Jared Jurkiewicz]

I can't really look at your suggestions without you being under CLA (contamination issues). The reason is basically to avoid any possible questions of code pedigree. It's basically to protect dojo down the road, not a slight on the suggestion you made or you at all.

If you want to file for a CLA, that would be awesome. Would make it a lot faster to put a fix in for this or whatnot. :)

[Jared Jurkiewicz]

And note: Suggestions being: Code you provide.

[niciliketo]

Replying to jaredj:

And note: Suggestions being: Code you provide.

Understood, I will file a CLA later today and let you know once it is done. Thanks for your help.

[niciliketo]

Hi Jared,

Sorry for the delay. I have now filed my CLA.

Thanks, Nic.

[Jared Jurkiewicz]

Okay, cool. I'll take a look at your changes and if they seem safe, integrate them. Thanks for taking the time to do the initial work as well as fill out the CLA. Glad to have you as a contributor!

[Jared Jurkiewicz]

Looking at this now. Found a couple places more than what you had that should have the CDATA check too ... so, applied them. Building a small testcase for it now off your supplied data file.

Should be able to get this in 1.2, so marking target as 1.2.

[Jared Jurkiewicz]

Quick patch + UT for adding CDATA support as part of the text handling.

[Jared Jurkiewicz]

Tested patch on:

Firefox 2.0.0.16

IE 6

Safari 3.1

Opera 9.2

Seamonkey 1.1.2

[Jared Jurkiewicz]

Fixed in changeset: ​http://bugs.dojotoolkit.org/changeset/14549