Opened 11 years ago

Closed 11 years ago

Last modified 7 years ago

#7189 closed defect (fixed)

UT failure: Safari: query.html::t::xml

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.2
Component: Core Version: 1.1.1
Keywords: Cc: Jared Jurkiewicz
Blocked By: Blocking:

Description

 TypeError: Value undefined (result of expression console.debug) is not object.
     ERROR IN:
 		 function xml() 
{
  try 
  {
    var doc = dojox.data.dom.createDocument(["","One","Two","Three","Four",""].join(""));
    var de = doc.documentElement;
    console.debug(dojox.data.dom.innerXML(de));
    doh.is(2, dojo.query("result", de).length);
    doh.is(1, dojo.query("Result", de).length);
    doh.is(1, dojo.query("RESULT", de).length);
    doh.is(0, dojo.query("resulT", de).length);
    doh.is(0, dojo.query("rEsulT", de).length);
  }
  catch (e)
  {
    console.debug(e);
  }
}
 FAILED test: ../../dojo/tests/_base/query.html::t::xml 0 ms

Change History (13)

comment:1 Changed 11 years ago by Adam Peller

createDocument seems to fail in all instances for me on Safari. Independent of that, should query depend on dojox for a test?

comment:2 Changed 11 years ago by Adam Peller

Cc: Jared Jurkiewicz added

comment:3 Changed 11 years ago by Jared Jurkiewicz

This: var doc = dojox.data.dom.createDocument(["","One","Two","Three","Four",""].join(""));

Isn't a valid call to dojox.data.dom.createDocument(). That string is not valid XML. I'm surprised that other browsers would even parse that with the DOMParser().

The test needs to be fixed up.

I'll see what I can do.

comment:4 Changed 11 years ago by Jared Jurkiewicz

Looking at this further. That line in the current test is valid xml. Something funny is going on.

comment:5 Changed 11 years ago by Jared Jurkiewicz

This looks like a firebug lite problem on Safari. console.debug isn't defined or somesuch. The error is:

undefined (result of expression console.debug) is not object.

Switching it to console.log works fine. Issue is in firebug lite with debug. Working up a small testcase to attach and route.

comment:6 Changed 11 years ago by Jared Jurkiewicz

Hm. simple testcase works fine. Not sure why console.debug appears undefined in this situation on safari. I've seen this oddity before, though, where console.debug doesn't work on Safari.

Firebug lite problem

comment:7 Changed 11 years ago by Adam Peller

filed #7193 about the misleading output. The real problem is console.debug not working in DOH on Safari. Remove the console.debug statements and the tests pass.

comment:8 Changed 11 years ago by Adam Peller

Owner: changed from alex to Mike Wilcox

comment:9 Changed 11 years ago by James Burke

I believe the console.debug issue is a larger Safari issue, being tracked in #6849

comment:10 Changed 11 years ago by Adam Peller

thanks, James. This whole thing might be a dup, then. console.log seems to work fine, so a workaround would just be to replace (or remove) the console.debug calls in the tests.

comment:11 Changed 11 years ago by Adam Peller

Owner: changed from Mike Wilcox to Adam Peller
Status: newassigned

comment:12 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: assignedclosed

(In [14532]) Workaround to fix errors in DOH in Safari where console.debug is used. Fixes #7189, refs #6849

comment:15 Changed 7 years ago by bill

In [29130]:

Remove vestigial code. Safari has it's own console now and doesn't use firebug lite anymore. Fixes #15613, refs #7189.

Note: See TracTickets for help on using tickets.